fix: add missing private clauses for GPU offload; disable ZFP in silo build

- Add h_iL, h_iR, h_avg_2 and other chemistry locals to private clauses
  of two GPU_PARALLEL_LOOP regions in s_hllc_riemann_solver (lines 2201,
  2421) where they were declared at subroutine scope but not privatized,
  causing nvfortran 25.1 gpu-omp to fail with 'Could not find
  allocated-variable index for symbol - h_il'
- Disable ZFP compression in silo (-DSILO_ENABLE_ZFP=OFF) since MFC
  never uses it and nvc crashes compiling zfp/decode1d.c on 23.11/25.3
- Pin silo to 4.12.0 tag with GIT_SHALLOW; clean up HDF5 build flags

Author: sbryngelson

src/simulation/m_riemann_solvers.fpp

@@ -2205,7 +2205,8 @@ contains
                                         & G_L, G_R, rho_avg, H_avg, c_avg, gamma_avg, ptilde_L, ptilde_R, vel_L_rms, vel_R_rms, &
                                         & vel_avg_rms, vel_L_tmp, vel_R_tmp, Ms_L, Ms_R, pres_SL, pres_SR, alpha_L_sum, &
                                         & alpha_R_sum, rho_Star, E_Star, p_Star, p_K_Star, vel_K_star, s_L, s_R, s_M, s_P, s_S, &
-                                        & xi_M, xi_P, xi_L, xi_R, xi_MP, xi_PP]')
+                                        & xi_M, xi_P, xi_L, xi_R, xi_MP, xi_PP, Ys_L, Ys_R, Cp_iL, Cp_iR, Xs_L, Xs_R, &
+                                        & Gamma_iL, Gamma_iR, Yi_avg, Phi_avg, h_iL, h_iR, h_avg_2]')
                     do l = is3%beg, is3%end
                         do k = is2%beg, is2%end
                             do j = is1%beg, is1%end
@@ -2423,7 +2424,8 @@ contains
                                         & qv_R, qv_avg, c_L, c_R, c_avg, vel_L_rms, vel_R_rms, vel_avg_rms, vel_L_tmp, vel_R_tmp, &
                                         & Ms_L, Ms_R, pres_SL, pres_SR, alpha_L_sum, alpha_R_sum, s_L, s_R, s_M, s_P, s_S, xi_M, &
                                         & xi_P, xi_L, xi_R, xi_MP, xi_PP, nbub_L, nbub_R, PbwR3Lbar, PbwR3Rbar, R3Lbar, R3Rbar, &
-                                        & R3V2Lbar, R3V2Rbar]')
+                                        & R3V2Lbar, R3V2Rbar, Ys_L, Ys_R, Cp_iL, Cp_iR, Xs_L, Xs_R, Gamma_iL, Gamma_iR, &
+                                        & Yi_avg, Phi_avg, h_iL, h_iR, h_avg_2]')
                     do l = is3%beg, is3%end
                         do k = is2%beg, is2%end
                             do j = is1%beg, is1%end

toolchain/dependencies/CMakeLists.txt

@@ -61,11 +61,13 @@ if (MFC_HDF5)
             GIT_PROGRESS   ON
             CMAKE_ARGS     "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}"
                             -DBUILD_SHARED_LIBS=OFF
-                            -DFORTRAN_LIBRARIES=ON
                             -DBUILD_TESTING=OFF
                             -DHDF5_BUILD_UTILS=OFF
                             -DHDF5_BUILD_TOOLS=ON
                             -DHDF5_BUILD_EXAMPLES=OFF
+                            -DHDF5_BUILD_CPP_LIB=OFF
+                            -DHDF5_BUILD_FORTRAN=OFF
+                            -DHDF5_ENABLE_PARALLEL=OFF
         )
     endif()
 endif()
@@ -82,13 +84,15 @@ if (MFC_SILO)
 
         ExternalProject_Add(silo
             GIT_REPOSITORY "https://github.com/LLNL/Silo"
-            GIT_TAG        0cddaa6865fb49ae7b2110fa1b6f2709592abe0b
+            GIT_TAG        4.12.0
+            GIT_SHALLOW    ON
             GIT_PROGRESS   ON
             PATCH_COMMAND  "${GIT_EXECUTABLE}" stash
                         && "${GIT_EXECUTABLE}" apply "${CMAKE_SOURCE_DIR}/Silo.patch"
             CMAKE_ARGS     -DSILO_ENABLE_SHARED=OFF
                            -DSILO_ENABLE_SILOCK=OFF
                            -DSILO_ENABLE_BROWSER=OFF
+                           -DSILO_ENABLE_ZFP=OFF
                            -DFIND_LIBRARY_USE_LIB64_PATHS=ON
                            "-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}"
                            "-DCMAKE_FIND_ROOT_PATH=${CMAKE_FIND_ROOT_PATH}"