Cases set only the parameters their equation of state reads (#1808)

Author: sbryngelson

.github/scripts/check_coverage_map_health.py

@@ -1,11 +1,10 @@
 """Fail loudly if the committed coverage map is stale or under-covers. Used by coverage-health.yml."""
 import datetime
-import subprocess
 import sys
 from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).resolve().parents[2] / "toolchain"))
-from mfc.test.coverage import COVERAGE_MAP_PATH, load_map, map_health  # noqa: E402
+from mfc.test.coverage import COVERAGE_MAP_PATH, _git, load_map, map_health  # noqa: E402
 from mfc.test.cases import list_cases  # noqa: E402  (returns the current test list)
 
 MAX_AGE_DAYS = 10
@@ -40,7 +39,7 @@ def verified_sha(cwd=None):
     caller must read that as undeterminable and fall back to the wall-clock age rule, not
     as a failure -- an absent ref is not evidence of a broken refresh.
     """
-    rev = subprocess.run(["git", "rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], capture_output=True, text=True, check=False, cwd=cwd)
+    rev = _git(["rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], cwd)
     return rev.stdout.strip() or None
 
 
@@ -53,10 +52,10 @@ def verified_after_last_change(git_sha, cwd=None):
     """
     if not git_sha:
         return None
-    last = subprocess.run(["git", "log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], capture_output=True, text=True, check=False, cwd=cwd)
+    last = _git(["log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], cwd)
     if last.returncode != 0 or not last.stdout.strip():
         return None  # shallow clone or no such commit -> fall back to the age rule
-    ancestor = subprocess.run(["git", "merge-base", "--is-ancestor", last.stdout.strip(), git_sha], capture_output=True, check=False, cwd=cwd)
+    ancestor = _git(["merge-base", "--is-ancestor", last.stdout.strip(), git_sha], cwd)
     return {0: True, 1: False}.get(ancestor.returncode)  # anything else -> None (unknown sha, shallow history)
 
 

examples/1D_advection_convergence/case.py

@@ -95,10 +95,8 @@
             "patch_icpp(1)%alpha(2)": "0.5 - 0.2 * sin(2.0 * pi * x / lx)",
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(2)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/1D_brio_wu/case.py

@@ -74,7 +74,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_brio_wu_hlld/case.py

@@ -75,7 +75,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_brio_wu_rmhd/case.py

@@ -76,7 +76,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_convergence/case.py

@@ -74,10 +74,8 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(2)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
         }
     )
 )

examples/1D_dai_woodward/case.py

@@ -83,7 +83,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / ((5.0 / 3.0) - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         },
     )
 )

examples/1D_dai_woodward_hlld/case.py

@@ -84,7 +84,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / ((5.0 / 3.0) - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         },
     )
 )

examples/1D_euler_convergence/case.py

@@ -100,7 +100,6 @@
             "patch_icpp(1)%alpha(1)": 1.0,
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/1D_hypo_2materials/case.py

@@ -83,7 +83,6 @@
             "fluid_pp(1)%G": 1.0e09,
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
             "fluid_pp(2)%G": 0.0,
         }
     )