Name the git helper the coverage health check imports as public

Author: sbryngelson

.github/scripts/check_coverage_map_health.py

@@ -4,7 +4,7 @@
 from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).resolve().parents[2] / "toolchain"))
-from mfc.test.coverage import COVERAGE_MAP_PATH, _git, load_map, map_health  # noqa: E402
+from mfc.test.coverage import COVERAGE_MAP_PATH, load_map, map_health, run_git  # noqa: E402
 from mfc.test.cases import list_cases  # noqa: E402  (returns the current test list)
 
 MAX_AGE_DAYS = 10
@@ -39,7 +39,7 @@ def verified_sha(cwd=None):
     caller must read that as undeterminable and fall back to the wall-clock age rule, not
     as a failure -- an absent ref is not evidence of a broken refresh.
     """
-    rev = _git(["rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], cwd)
+    rev = run_git(["rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], cwd)
     return rev.stdout.strip() or None
 
 
@@ -52,10 +52,10 @@ def verified_after_last_change(git_sha, cwd=None):
     """
     if not git_sha:
         return None
-    last = _git(["log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], cwd)
+    last = run_git(["log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], cwd)
     if last.returncode != 0 or not last.stdout.strip():
         return None  # shallow clone or no such commit -> fall back to the age rule
-    ancestor = _git(["merge-base", "--is-ancestor", last.stdout.strip(), git_sha], cwd)
+    ancestor = run_git(["merge-base", "--is-ancestor", last.stdout.strip(), git_sha], cwd)
     return {0: True, 1: False}.get(ancestor.returncode)  # anything else -> None (unknown sha, shallow history)
 
 

toolchain/mfc/test/coverage.py

@@ -222,13 +222,13 @@ def _env_without_git():
     return {k: v for k, v in os.environ.items() if not k.startswith("GIT_")}
 
 
-def _git(args, cwd, timeout=60):
+def run_git(args, cwd, timeout=60):
     return subprocess.run(["git", *args], capture_output=True, text=True, cwd=cwd, timeout=timeout, check=False, env=_env_without_git())
 
 
 def _merge_base(cwd, branch):
     for ref in (branch, f"origin/{branch}"):
-        r = _git(["merge-base", ref, "HEAD"], cwd)
+        r = run_git(["merge-base", ref, "HEAD"], cwd)
         if r.returncode == 0 and r.stdout.strip():
             return r.stdout.strip()
     return None
@@ -252,12 +252,12 @@ def get_changed_files(root_dir, compare_branch="master", explicit: Optional[str]
     try:
         base = _merge_base(root_dir, compare_branch)
         if base is None:
-            _git(["fetch", "origin", f"{compare_branch}:{compare_branch}", "--depth=1"], root_dir, 120)
-            _git(["fetch", "--deepen=200"], root_dir, 120)
+            run_git(["fetch", "origin", f"{compare_branch}:{compare_branch}", "--depth=1"], root_dir, 120)
+            run_git(["fetch", "--deepen=200"], root_dir, 120)
             base = _merge_base(root_dir, compare_branch)
         if base is None:
             return None
-        diff = _git(["diff", base, "HEAD", "--name-only", "--no-color"], root_dir)
+        diff = run_git(["diff", base, "HEAD", "--name-only", "--no-color"], root_dir)
         if diff.returncode != 0:
             return None
         return {f for f in diff.stdout.splitlines() if f.strip()}