Skip to content

ci: use Intel ifx/icx compilers in Intel CI jobs - #1342

Merged
sbryngelson merged 5 commits into
masterfrom
fix-intel-ifx
Apr 1, 2026
Merged

ci: use Intel ifx/icx compilers in Intel CI jobs#1342
sbryngelson merged 5 commits into
masterfrom
fix-intel-ifx

Conversation

@sbryngelson

@sbryngelson sbryngelson commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

The Intel matrix entries in the test suite install oneAPI and source setvars.sh, which puts Intel compilers on PATH but does not set FC/CC/CXX. Without these, CMake finds gfortran first and the "Intel" CI jobs silently test gfortran instead of ifx.

This PR sets:

  • FC=ifx, CC=icx, CXX=icpx — so CMake uses Intel compilers
  • MPIFC=mpiifx, MPICC=mpiicx, MPICXX=mpiicpx — so find_package(MPI) picks up Intel MPI wrappers

Test plan

  • CI: Github (ubuntu, mpi, reldebug, true) builds with IntelLLVM compiler identification
  • CI: Github (ubuntu, mpi, no-debug, true) builds and tests pass with ifx

The Intel matrix entries install oneAPI and source setvars.sh, which puts
Intel compilers on PATH but does not set FC/CC/CXX. Without these, CMake
finds gfortran first and the 'Intel' CI jobs silently test gfortran
instead of ifx. Also set MPIFC/MPICC/MPICXX so CMake find_package(MPI)
picks up Intel MPI wrappers (mpiifx, mpiicx, mpiicpx).
icx/icpx are not installed (only intel-oneapi-compiler-fortran is).
Filter CC/CXX from setvars.sh export so CMake uses gcc for C/CXX.
Add intel-oneapi-compiler-dpcpp-cpp to provide icx/icpx alongside ifx.
Set all Intel compiler env vars (FC, CC, CXX, MPI wrappers).
@sbryngelson
sbryngelson marked this pull request as ready for review April 1, 2026 11:58
@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bdc8a04a-f151-4e9b-9770-6a30d70784ac

📥 Commits

Reviewing files that changed from the base of the PR and between 336487c and 31f403b.

📒 Files selected for processing (2)
  • .github/workflows/test.yml
  • CMakeLists.txt

📝 Walkthrough

Walkthrough

The pull request extends the GitHub Actions test workflow to add support for Intel oneAPI compilers. The Ubuntu (Intel) setup step now installs the additional intel-oneapi-compiler-dpcpp-cpp package and explicitly sets environment variables for Intel Fortran, C, and C++ compilers along with their MPI variants (ifx, icx, icpx, mpiifx, mpiicx, mpiicpx). A corresponding comment is added to CMakeLists.txt documenting this Intel compiler CI support.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: enabling Intel ifx/icx compilers in CI jobs.
Description check ✅ Passed The PR description provides clear context, motivation, and test results, though it omits some template sections like explicit type categorization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbryngelson
sbryngelson merged commit c76be93 into master Apr 1, 2026
56 checks passed
@sbryngelson
sbryngelson deleted the fix-intel-ifx branch April 1, 2026 12:07
@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.67%. Comparing base (336487c) to head (a83c814).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1342   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files          70       70           
  Lines       18249    18249           
  Branches     1504     1504           
=======================================
  Hits        11803    11803           
  Misses       5491     5491           
  Partials      955      955           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant