Fix LF volume-fraction flux and interface velocity - #1828
Closed
aliencaocao wants to merge 1 commit into
Closed
Conversation
aliencaocao
marked this pull request as draft
September 5, 2026 19:12
aliencaocao
marked this pull request as ready for review
September 5, 2026 19:12
Member
|
pr no checkmark |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Fixes the Lax–Friedrichs/HLL-type volume-fraction flux computation by incorporating interface advection velocity in the flux and adjusts how the geometric source term is formed (per linked issue #1818).
Changes:
- Update
flux_rsx_vfto include left/right interface velocities in the volume-fraction flux. - Change
flux_src_rsx_vfcomputation to a single “interface velocity” value. - Set void-fraction geometric source flux to zero (instead of copying the advection flux).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
313
to
+314
| end do | ||
| flux_src_rsx_vf(${SF('')}$, eqn_idx%adv%beg) = (s_M*vel_R(norm_dir) - s_P*vel_L(norm_dir))/(s_M - s_P) |
Comment on lines
+309
to
+312
| flux_rsx_vf(${SF('')}$, i) = (s_M*qR_prim_rsx_vf(${SF(' + 1')}$, & | ||
| & i)*vel_R(norm_dir) - s_P*qL_prim_rsx_vf(${SF('')}$, & | ||
| & i)*vel_L(norm_dir) + s_M*s_P*(qL_prim_rsx_vf(${SF('')}$, & | ||
| & i) - qR_prim_rsx_vf(${SF(' + 1')}$, i)))/(s_M - s_P) |
Lines of Code
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1818. For context and description of issue and fix, please refer to the issue thread.
Contribution Policy
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
Acknowledgement
PR template credit: junegunn