Skip to content

ci: identify faulted node via sacct when the .out marker is missing #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 2 commits into from
Sep 8, 2026
+11 −0
Merged

ci: identify faulted node via sacct when the .out marker is missing #1835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1f9cce
ci: identify faulted node via sacct when the .out marker is missing
sbryngelson Sep 8, 2026
f046780
Merge branch 'master' into ci-node-exclude-sacct-fallback
sbryngelson Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/scripts/submit-slurm-job.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,17 @@ while :; do
# another node. Note bench-pair.sh probes only after building both trees, so
# a fault there discards those builds and the resubmit repeats them.
faulted_node=$(bash "$SCRIPT_DIR/node-exclude.sh" node-from "$output_file")
# Fall back to SLURM's own record when the MFC_FAULT_NODE marker is
# unreadable. A job that dies before its .out is flushed (or before NFS
# makes it visible) leaves no marker, so node-from returns empty; the
# merge below then adds nothing and SLURM re-draws the SAME bad node. A
# dead-GPU V100 (atl1-1-02-006-34-0, cuInit 999) ate both attempts of run
# 34183404644 exactly this way. sacct knows the node whether or not the
# .out exists, so identification no longer depends on the marker.
if [ -z "$faulted_node" ]; then
faulted_node=$(sacct -j "$job_id" -X -n -o NodeList 2>/dev/null | head -n1 | tr -d ' ')
case "$faulted_node" in ""|None*|*[,\[]*) faulted_node="" ;; esac
fi
if [ "$node_attempt" -lt "$MFC_MAX_NODE_RESUBMITS" ]; then
node_attempt=$((node_attempt + 1))
node_exclude=$(bash "$SCRIPT_DIR/node-exclude.sh" merge "$node_exclude" "$faulted_node")
Expand Down
Loading