Raise the probe limit from 10 to 64 - #1845
Conversation
`num_probes_max` also bounds the acoustic source array, and 10 is restrictive for sensor arrays: a single sparse-sensing study here needs 24 probes on a flapping wing and 38 on a jet (a lip ring, a lip line, a centreline rake and a near-field acoustic arc), so the present limit forces a case to be split or instrumented less than intended. The arrays this bounds hold three reals per probe, so the static cost of the change is negligible. Claude-Session: https://claude.ai/code/session_01HMJ7cycfo7kTFSFq5yhHLG
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Raises the maximum supported number of probes to accommodate larger sensor/acoustic arrays without splitting cases.
Changes:
- Increased the
num_probes_maxlimit from 10 to 64 in the Fortran constants. - Updated the toolchain default/lookup to match the Fortran constant for
num_probes_max.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| toolchain/mfc/params/definitions.py | Updates NPR default to 64 to stay in sync with the Fortran constant. |
| src/common/m_constants.fpp | Raises num_probes_max to 64, increasing the compile-time probe array bounds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
- Coverage 62.75% 61.26% -1.50%
==========================================
Files 84 84
Lines 22045 22330 +285
Branches 3238 3265 +27
==========================================
- Hits 13834 13680 -154
- Misses 5981 6207 +226
- Partials 2230 2443 +213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
num_probes_max(which also bounds the acoustic source array) is 10. That is restrictive for sensor arrays: the study I am running needs 24 probes on a flapping wing and 38 on a jet — a lip ring, a lip line, a centreline rake and a near-field acoustic arc — so the current limit forces a case to be split or instrumented less than intended.The bounded arrays hold three reals per probe, so the static cost of raising the limit is negligible. The toolchain default in
params/definitions.pyis kept in step with the Fortran constant, as the co-location check requires.Tested on Frontier with a 24-probe 3D case: all 24 probe files are written.
https://claude.ai/code/session_01HMJ7cycfo7kTFSFq5yhHLG