Merge pull request #54 from MHFU-ModKit/studio/send-hitboxes

feat(studio): Send hitboxes to game

Author: sp00ktober

apps/studio/src/mhfu_studio/monster/panels/action.py

@@ -42,7 +42,7 @@
 EVERYWHERE = {"UNMEASURED"}
 LUA_NOTE = (
     "The game reads moves from your mod's Lua file, not from this file. Copy them into the"
-    " mod's P.define{…}; Send to game carries only the hitboxes."
+    " mod's P.define{…}; Send hitboxes to game carries nothing else."
 )
 ROWS_TIP = (
     "Every action worth a clip: your moves, then the base monster's attacks, then what the game"

apps/studio/src/mhfu_studio/monster/panels/hitboxes.py

@@ -229,7 +229,7 @@ def __init__(self, ws: MonsterWorkspace, studio: Studio) -> None:
         lay.addWidget(edit)
 
         ship = kit.Section(
-            "4  Send to game", tip="Your hitboxes onto the memory stick, or into the game"
+            f"4  {ws.send_label}", tip="Your hitboxes onto the memory stick, or into the game"
         )
         self.send = SendRow(ws, studio)
         self.push = PushRow(ws, studio)

apps/studio/src/mhfu_studio/monster/panels/push.py

@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 # SPDX-FileCopyrightText: 2026 sp00ktober
-"""Push to game, beside Send to game: the hit tables straight into the running game."""
+"""Push to game, beside Send hitboxes to game: the hit tables straight into the running game."""
 
 from __future__ import annotations
 

apps/studio/src/mhfu_studio/monster/panels/widgets.py

@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 # SPDX-FileCopyrightText: 2026 sp00ktober
 """Qt pieces the monster panels share: the source switch, a volume's form, the no-scene state,
-the see-through switch and the Send to game row."""
+the see-through switch and the Send hitboxes to game row."""
 
 from __future__ import annotations
 
@@ -130,13 +130,13 @@ def sync_see_through(box: QCheckBox, ws: MonsterWorkspace) -> None:
 
 
 class SendRow(QWidget):
-    """The title bar's Send to game where a panel's task ends, and why it cannot run."""
+    """The title bar's Send hitboxes to game where a panel's task ends, and why it cannot run."""
 
     def __init__(self, ws: MonsterWorkspace, studio: Studio) -> None:
         super().__init__()
         self.ws, self.studio = ws, studio
         self.send = kit.button(
-            "Send to game",
+            ws.send_label,
             tip="Puts your hitboxes, hurtboxes and damage grid on the memory stick, saved or"
             " not; a running game reloads them. The title bar's button (⌘↩) does the same.",
             on=studio.act("send", studio.send),

apps/studio/src/mhfu_studio/monster/push.py

@@ -138,5 +138,5 @@ def stick_differs(m: Manifest, mods: Path) -> str:
         return ""
     return (
         f"; the memory stick's {path.name} (id {found[1]}) puts its own tables back while the"
-        " port is in the area: Send to game to put these there too"
+        " port is in the area: Send hitboxes to game to put these there too"
     )

apps/studio/src/mhfu_studio/monster/validate.py

@@ -580,7 +580,7 @@ def _attacks(m: Manifest, intel: SpeciesIntel | None) -> list[Finding]:
     if attacks is None or not attacks.present:
         msg = (
             f"no attack data for {species.label(host)}: hit groups, attack ids and sizes are "
-            "not checked, and Send to game refuses until there is."
+            "not checked, and Send hitboxes to game refuses until there is."
         )
         out.append(_f("warning", "HITBOX_UNCHECKED", "hitbox", msg))
         return out

apps/studio/src/mhfu_studio/monster/workspace.py

@@ -123,6 +123,7 @@ class _Warm:
 class MonsterWorkspace(Workspace):
     name = "monster"
     filters = ("Port manifest", "*.toml", "Monster PAC", "*.bin *.pac")
+    send_label = "Send hitboxes to game"
 
     def __init__(self, data: Data | None = None, intel_root: Path | None = None) -> None:
         self._data = data
@@ -131,7 +132,7 @@ def __init__(self, data: Data | None = None, intel_root: Path | None = None) ->
         self._found = _roots()
         #: what the last `warmup` read, for `open` to take
         self._warm: _Warm | None = None
-        #: the manifest as the last Send to game sent it
+        #: the manifest as the last Send hitboxes to game sent it
         self._sent: Manifest | None = None
         #: species intel from this directory instead of the cache built from the game
         self.intel_root = intel_root
@@ -317,7 +318,7 @@ def next_steps(self) -> Sequence[Step]:
             Step("Pick an action", self.pair is not None),
             Step("Copy the base monster's hitboxes", bool(m.hitboxes)),
             Step("Change one", self._hitboxes_changed(m)),
-            Step("Send to game", self._sent is m, SEND_KEY),
+            Step(self.send_label, self._sent is m, SEND_KEY),
         )
 
     def _hitboxes_changed(self, m: Manifest) -> bool:

apps/studio/src/mhfu_studio/shell/workspace.py

@@ -157,6 +157,8 @@ class Workspace(Protocol):
     name: str
     #: open-dialog filters as (name, pattern) pairs: ("Port manifest", "*.toml", ...)
     filters: Sequence[str] = ("All files", "*")
+    #: the title bar's send button, saying what this workspace sends
+    send_label: str = "Send to game"
     #: how often `message` was set: the studio shows each one, a repeat too
     said: int = 0
     _message: str = ""

apps/studio/src/mhfu_studio/ui/window.py

@@ -633,6 +633,7 @@ def _fill_view_menu(self, ws: Workspace) -> None:
     def _sync_send(self) -> None:
         """Send only sends, Stop only stops; the title bar's button is Stop while a job runs."""
         job, why = self.studio.job, self.studio.send_blocker()
+        self.send_action.setText(self.studio.active.send_label)
         for a, tip, on in (
             (self.send_action, why or chrome.SEND_TIP, why is None),
             (self.stop_action, STOP_TIP if job is None else f"Stops {job.title}", job is not None),
@@ -795,7 +796,8 @@ def _sync_window(self, ws: Workspace) -> None:
         self.message.setToolTip(message)  # the bar clips it
         hint = ws.hint()
         if hint and self.send_action.isEnabled():  # `_sync_send` asked the workspace
-            hint += f" \u00b7 {about.native(self.send_action.shortcut())} send to game"
+            label = self.studio.active.send_label.lower()
+            hint += f" \u00b7 {about.native(self.send_action.shortcut())} {label}"
         self.hint.setText(hint)
         self.hint.setToolTip(hint)
         self._sync_problems()

apps/studio/tests/ui/test_job.py

@@ -5,6 +5,7 @@
 from typing import Any
 
 import pytest
+from mhfu_studio.monster.workspace import MonsterWorkspace
 from mhfu_studio.shell import studio as studio_module
 from mhfu_studio.shell.workspace import Job
 from mhfu_studio.ui.job import ProcessRunner
@@ -130,3 +131,12 @@ def test_message_tip(make_window: Make) -> None:
     w.studio.message = "x" * 400
     w.sync()
     assert w.message.toolTip() == "x" * 400
+
+
+def test_send_says_what_it_sends(make_window: Make) -> None:
+    ws = Sender(Job("help", ("--help",)))
+    ws.send_label = "Send hitboxes to game"
+    w = make_window(ws, FakeWorkspace("monster"))
+    w.sync()
+    assert w.bar.send.text() == "Send hitboxes to game"
+    assert MonsterWorkspace.send_label == "Send hitboxes to game"