Repository navigation
fix(ppsspp-debug): Client.close() is safe from several threads - #47
Merged
Merged
Conversation
A second close could schedule onto a loop the first had stopped and wait on it forever. A lock orders scheduling against stop, stop runs once and later callers wait for it, and close ignores the Disconnected of a client closed meanwhile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two threads closing one
Clientcould hang: the second close scheduled onto a loop the first had already stopped and waited on it forever (seen in the HUD's tests, modkit#46). A lock now orders scheduling against stop,_Loop.stopruns once and later callers wait for it, andcloseignores theDisconnectedof a client closed meanwhile.Tested:
test_close_from_many_threads(40 clients, 4 closers each) failed on main 3 of 3 runs and passes 15 of 15 now;pytest packages/ppsspp-debug packages/mhfu381 passed, 49 skipped; mypy strict, pre-commit.🤖 Generated with Claude Code