Repository navigation
fix: delegate reset to decorated adapter instead of clear - #12
Merged
Merged
Conversation
alekseytupichenkov
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SchemaAwareRedisAdapter::reset()calleddecorated->clear()after every messenger message. That triggers RedisINFO Serverinside SymfonyRedisTrait::doClear()and causes periodicUndefined array key "redis_version"warnings in Sentry.Schema isolation for Redis cache is handled by
prefixKey()during read/write operations, usingBaggageSchemaResolver(baggage /preview-envheader /BaggageSchemaStampin messenger). It is not handled byreset().In messenger workers, schema-aware
clear($prefix)inreset()does not work as intended:BaggageSchemaMiddlewareresetsBaggageSchemaResolverin itsfinallyblock beforeResetServicesListenercallsSchemaAwareRedisAdapter::reset(). At that pointgetSchema()always returnsenvironmentSchema, so the code always executedclear('')— wiping the entirecache_storage*namespace and hitting Redis on every message.ResettableInterfaceshould reset in-memory adapter state (deferred,ids), not flush Redis.What Changed
reset()delegates todecorated->reset()instead ofclear()reset()callsresetphp_codesnifferto^3.13(CVE-2026-67434)phpcs.xml.distforbidden-functions syntax for PHPCS 3.13Reviewer Guide
BaggageSchemaMiddlewarecleans schema state; adapterreset()only clears in-memory cache bookkeeping.prefixKey()is unchanged — preview/staging isolation still works during message handling.Test plan
vendor/bin/phpunitvendor/bin/phpstan analysevendor/bin/phpcs