Skip to content

Commit 052fbaf

Browse files
authored
Merge pull request #5 from MachineWisdomAI/claude/mcp-walkthrough-repairs
docs(mcp): refresh the walkthrough and add a Why SAGA chapter
2 parents 822c1cf + 6a1ba66 commit 052fbaf

3 files changed

Lines changed: 19 additions & 12 deletions

File tree

‎apps/mcp/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ A standalone MCP application. `answer_islamic_question` calls the Ansari API and
44

55
## How it works
66

7-
[Explore the interactive walkthrough](docs/show-me-ansari-mcp.html) for the complete question-to-card flow, UI states, code ownership and build process. Its hosted lifecycle addendum compares Alexa+, ChatGPT and Claude from build and deployment through discovery, requests, rendering and teardown. Download the self-contained HTML and open it in a browser; GitHub displays its source. The walkthrough uses synthetic content and makes no live requests.
7+
[Explore the interactive walkthrough](docs/show-me-ansari-mcp.html) for the complete question-to-card flow, UI states, code ownership, build process and why it builds on SAGA. Download the self-contained HTML and open it in a browser; GitHub displays its source. The walkthrough uses synthetic content and makes no live requests.
88

99
## Screenshots
1010

‎apps/mcp/docs/show-me-ansari-mcp.html‎

Lines changed: 13 additions & 11 deletions
Large diffs are not rendered by default.

‎codev/reviews/301-faithful-answers-mcp.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# 301: Review and verification
22

3+
## Original contribution
4+
35
Destination build, typechecking, 19 server/packaging tests and 47 Chromium checks passed. Frozen installation of the application dependency closure passed. All seven existing lockfile importers are preserved byte-for-byte, and existing dependency snapshots are retained; new entries are additive. Public CI verifies both the destination lockfile and a fresh standalone resolution.
46

57
Independent Codex static consultation found no blocking integration defects. It verified runtime Turbo environment declarations, package-relative container paths and preserved existing development services. Its observation that isolated CI alone did not exercise the root lockfile was addressed by adding explicit frozen-lockfile application verification.
@@ -9,6 +11,7 @@ The destination's esbuild override resolves a newer patch than the source applic
911
Claude and Gemini consultation were not completed; the three-model ASPIR consultation is incomplete. Independent Codex review is recorded separately and does not represent those missing reviews. Upstream merge remains a maintainer decision.
1012

1113
Fresh public-only isolated installation, build, typecheck, 19 server tests, 47 browser checks, uncached Docker build and no-network/no-mount runtime smoke all passed. The runtime smoke verifies one tool/current resource, complete answer preservation, safe failure and recovery, content-addressed HTML and graceful shutdown.
14+
1215
## Destination-branch host verification
1316

1417
The app from commit `ef6b9724a8bb8541fecbf37dc5a21449b8e2e920` was built using the four public `@saga-a2ui/*@0.5.4-rc.1` packages and deployed to DEV. On 2026-10-21, representative synthetic greeting answers rendered in ChatGPT, Claude and the Alexa+ simulator. Each rendered document reported the exact destination revision, version `0.12.7`, and loaded Kitab regular and bold fonts. Complete answer text, Ansari attribution and the separate “Built with saga a2ui” footer were present.
@@ -59,4 +62,6 @@ Discovery restores the existing `answer_islamic_question` name and detailed desc
5962

6063
Validation passed: application lint and typecheck, Node and Worker builds, all 142 server/packaging tests, 73 browser checks, an uncached Node 22 container build with a no-network/no-mount smoke test, and the production release check against the public npm registry. The tests exercise both JSON and SSE deadline cancellation, the actual 60-second Node/Worker deadline, configured localhost rejection, input boundaries, deployment-command ordering and built-artifact notices. Gitleaks found no leaks in the repair commits.
6164

65+
The walkthrough's source links now point at `apps/mcp` at `822c1cf`, whose files match the sources the walkthrough embeds, replacing the earlier links to the 0.16.5 revision. Its licence notice carries the MIT artwork grant from `assets/NOTICE.md`.
66+
6267
Caller disconnection in the local Worker runtime does not immediately close the upstream socket; the verified request deadline does. No SDK lifecycle change is included. These source repairs have not been deployed. Existing host acceptance is recorded in the application README with its original revisions and dates; no fresh stable-version Alexa acceptance is claimed. Independent review and CI for this repair are recorded on its fork pull request. Upstream merge remains a maintainer decision.

0 commit comments

Comments
 (0)