Skip to content

Commit cac034b

Browse files
committed
docs(mcp): record review repair validation
1 parent f790d48 commit cac034b

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎codev/reviews/301-faithful-answers-mcp.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,13 @@ The standalone package now lives at `apps/ansari-faithful-answers`, using the re
5050
Fresh qualification from the relocated package passed: root frozen offline installation, frozen application-filtered installation with Node 22, package selection, typecheck, build, all 24 server/packaging tests and 55 browser checks. The public-only isolated installation passed the same application checks, followed by an uncached Node 22 Docker build and no-network/no-mount runtime smoke. The smoke verified complete answer preservation, safe failure/recovery, content-addressed HTML and graceful shutdown. Existing root development commands and package-relative Docker context are unchanged.
5151

5252
Separate independent Codex requirements and standards reviews found no actionable issues in the migration. Placement assertions failed against the old directory before the move and passed afterward; walkthrough JavaScript syntax and historical source targets were also checked. This path correction does not establish a new deployment or actual-host acceptance. The existing upstream contribution remains open for maintainer review; no merge, deployment or package release is included.
53+
54+
## PR #323 review repairs (0.16.6)
55+
56+
The application now lives at `apps/mcp` as `ansari-mcp`, with one root lockfile, shared lint configuration, filtered root build/test commands and a root-context container build. Existing dependency snapshots are unchanged from contribution commit `137c96aac956ce9d56a9f814d3bbb3bf80136555`; the Markdown adapter override is scoped to its actual direct parent. The release checker selects the MCP importer from the root lockfile.
57+
58+
Discovery restores the existing `answer_islamic_question` name and detailed descriptions, adds read-only/open-world annotations, and limits questions to 1–4000 UTF-16 code units. The SDK request signal reaches the upstream fetch. Explicit host/origin configuration replaces development defaults. The beta and production aliases invoke the release checker before building or deploying. Distributed HTML retains the installed SAGA licences and notices, the application MIT licence, artwork MIT notice and font notices.
59+
60+
Validation passed: application lint and typecheck, Node and Worker builds, all 142 server/packaging tests, 73 browser checks, an uncached Node 22 container build with a no-network/no-mount smoke test, and the production release check against the public npm registry. The tests exercise both JSON and SSE deadline cancellation, the actual 60-second Node/Worker deadline, configured localhost rejection, input boundaries, deployment-command ordering and built-artifact notices. Gitleaks found no leaks in the repair commits.
61+
62+
Caller disconnection in the local Worker runtime does not immediately close the upstream socket; the verified request deadline does. No SDK lifecycle change is included. These source repairs have not been deployed. Existing host acceptance is recorded in the application README with its original revisions and dates; no fresh stable-version Alexa acceptance is claimed. Independent review and CI for this repair are recorded on its fork pull request. Upstream merge remains a maintainer decision.

0 commit comments

Comments
 (0)