Repository navigation
fix(mcp): address workspace, runtime and release review comments - #3
Merged
timeleft-- merged 6 commits intoOct 28, 2026
Merged
Conversation
yia-mw-agent
approved these changes
Oct 28, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Helmet-Review-Request: #3 (comment)
Reviewed the full merge-base-to-head diff against codex/ansari-faithful-answers-076 (merge-base 137c96a, head fc40c24, 94 files, six commits). No material defects found.
Examined:
- Workspace move to
apps/mcp/ansari-mcp: root lockfile importer, catalogtypescript/eslint, shared@ansari/eslint-config, root--filter=!ansari-mcptask exclusions, and the scoped@a2ui/react@0.13.0>@a2ui/markdown-itoverride. - Root-context
Dockerfile, expanded root.dockerignore(committed.env.ci/.env.examplefiles stay available to the api and auth images),verify-container.shand the newmcp.ymlworkflow. - Legacy
answer_islamic_questioncontract: description,readOnlyHint/openWorldHint, 1-4000 character validation, and the request signal passed to upstream fetch. runtime-config.ts: configured host and origin lists replace the local defaults, including an explicitly empty list.- Release gates: importer-scoped lockfile reading in
check-release.mjs, and the beta/production deploy scripts running the gate before build or Wrangler. - Licence notices embedded in the distributed HTML, and the SAGA credit link.
Validation run at the exact head (fc40c24, verified with git rev-parse HEAD):
pnpm install --frozen-lockfile --strict-peer-dependencies --filter ansari-mcp...passed.- The same install from a Dockerfile-shaped context (root manifests, packages,
apps/mcp/package.jsononly) also passed. pnpm mcp lint,typecheck,buildandbuild:worker(Wrangler dry run) passed.pnpm mcp test: 142 of 142 passed.- Browser checks: 73 checks, no errors.
check:release --target productionpassed against the public registry.- Live PR checks are all green: MCP application (includes the container build and smoke), api, auth, frontend, gitleaks.
Not run locally: the Docker image build, because no Docker daemon is available here. The MCP application CI job covers it and passed.
Non-blocking observations:
apps/mcp/wrangler.jsoncsetsMCP_ALLOWED_ORIGINSto an empty string, which now means no browser Origin is accepted (clients that send no Origin header are unaffected). This matches the new explicit-empty semantics and is covered by tests, but deployers should know before enabling browser clients.- Root
pnpm typecheck,testandbuildnow excludeansari-mcp, so onlymcp.ymland root lint cover it. That is deliberate, and the path filters inmcp.ymlare comprehensive.
timeleft--
merged commit Oct 28, 2026
07bdfb1
into
codex/ansari-faithful-answers-076
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the concrete review comments on upstream PR #323. Targets the existing contribution branch so the upstream contribution remains one PR.
apps/mcp/ansari-mcp, use the root lockfile and shared lint configuration, filter root commands and CI inputs, and build the compiled-only container from the repository root.answer_islamic_questiondiscovery contract with read-only/open-world annotations, validate 1–4000-character questions, pass the SDK request signal to upstream fetch, and make configured allowlists replace development defaults.Validation passed: app lint/typecheck, Node and Worker builds, 142 server/packaging tests, 73 browser checks, uncached Node 22 container build plus isolated smoke, public-registry production release check, Turbo command selection and Gitleaks. Dependency snapshots are unchanged from the base contribution. The walkthrough's 17 embedded source files match the application.
The actual 60-second request deadline cancels upstream fetch in Node and local Workers. A disconnected local Worker caller does not immediately close the upstream socket; the deadline still bounds it. Existing host receipts retain their original revisions and dates. This PR performs no deployment and makes no new stable-version Alexa acceptance claim. Upstream merge remains a maintainer decision.