Repository navigation
docs(mcp): correct Docker context and naming after the review repairs - #4
Merged
timeleft-- merged 1 commit intoOct 28, 2026
Merged
Conversation
The review repairs moved the app to apps/mcp and its image to the repository-root build context, but some prose still described the old layout: - arch.md said the MCP image's context was its own directory; it now builds from the root like api and auth. - The root README heading still used "Faithful Answers" and called the Docker build standalone. - The 301 review's placement section read as current; it is now past tense and points to the later rename. - The app README, two test comments and .dockerignore still mentioned the removed standalone verification copy, an app-local lockfile, or "both" service images. Comments and prose only; no behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
approved these changes
Oct 28, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full merge-base-to-head diff (base codex/ansari-faithful-answers-076 at 07bdfb1, head 65112f6, 7 files, +10/-11, prose and comments only). No material defects.
Checked:
- The new "all three images (api, auth, mcp) build from the repo root" wording in codev/resources/arch.md matches the code. apps/mcp/Dockerfile uses WORKDIR /repo and copies the root lockfile and
packages, as the api and auth Dockerfiles do. - The 301 review's "later renamed apps/mcp" and "PR iaser-ai#323 repairs moved the Docker context to the repository root" statements match the existing "PR iaser-ai#323 review repairs (0.16.6)" section in the same file.
- The README heading and Docker wording, the .dockerignore comment, the apps/mcp/README.md and the two test comments are accurate, with no stray references to the removed "standalone verification copy".
- No behaviour or code paths are changed, so no version bump is correct.
Validation on the exact head: pnpm install --frozen-lockfile --filter ansari-mcp..., pnpm mcp build and build:worker succeed. copy-boundary.test.ts and packaging.test.ts pass 9 of 9, and eslint in apps/mcp is clean.
Non-blocking: the 301-* spec, plan and review filenames keep the old name, which the PR description says is deliberate.
Helmet-Review-Request: #4 (comment)
timeleft--
merged commit Oct 28, 2026
822c1cf
into
codex/ansari-faithful-answers-076
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review repairs for iaser-ai/ansari#323. Those repairs moved the app to
apps/mcpand built its image from the repository root, but a few passages still described the old layout. This PR corrects them. It changes prose and comments only, with no behaviour change.codev/resources/arch.mdREADME.mdcodev/reviews/301-faithful-answers-mcp.mdapps/ansari-faithful-answers"apps/mcprename. The history is kept.apps/mcp/README.md,test/copy-boundary.test.tsapps/mcp/test/packaging.test.ts.dockerignoreNot changed: the walkthrough's links to
apps/ansari-faithful-answersare permalinks to a fixed commit. The301-faithful-answers-mcpspec, plan and review filenames are also unchanged; renaming them is a separate decision.Validation:
pnpm mcp lintis clean. Afterpnpm mcp buildandbuild:worker,copy-boundary.test.tsandpackaging.test.tspass 9 of 9. No version bump, because this changes docs and comments only.🤖 Generated with Claude Code