Skip to content

docs(mcp): correct Docker context and naming after the review repairs - #4

Merged
timeleft-- merged 1 commit into
codex/ansari-faithful-answers-076from
claude/mcp-doc-repairs
Oct 28, 2026
Merged

timeleft-- merged 1 commit into
codex/ansari-faithful-answers-076from
claude/mcp-doc-repairs

Conversation

@timeleft--

Copy link
Copy Markdown
Member

Follow-up to the review repairs for iaser-ai/ansari#323. Those repairs moved the app to apps/mcp and built its image from the repository root, but a few passages still described the old layout. This PR corrects them. It changes prose and comments only, with no behaviour change.

File Was Now
codev/resources/arch.md "Its Docker context is its own directory, unlike the API/auth images"; "Both images build from the repo root" Like api and auth, the MCP image builds from the repo root; "All three images (api, auth, mcp)"
README.md Heading "Faithful Answers MCP application"; "its standalone Docker build" "MCP application"; a Docker build that uses the repository root as context
codev/reviews/301-faithful-answers-mcp.md The placement section said the package "now lives at apps/ansari-faithful-answers" Past tense, with a pointer to the later apps/mcp rename. The history is kept.
apps/mcp/README.md, test/copy-boundary.test.ts Referred to the removed "standalone verification copy" Docker build context only
apps/mcp/test/packaging.test.ts The comment described an app-local lockfile Root lockfile only, which the code below it already asserts
.dockerignore "both service Dockerfiles" "every service Dockerfile"

Not changed: the walkthrough's links to apps/ansari-faithful-answers are permalinks to a fixed commit. The 301-faithful-answers-mcp spec, plan and review filenames are also unchanged; renaming them is a separate decision.

Validation: pnpm mcp lint is clean. After pnpm mcp build and build:worker, copy-boundary.test.ts and packaging.test.ts pass 9 of 9. No version bump, because this changes docs and comments only.

🤖 Generated with Claude Code

The review repairs moved the app to apps/mcp and its image to the
repository-root build context, but some prose still described the old
layout:

- arch.md said the MCP image's context was its own directory; it now
  builds from the root like api and auth.
- The root README heading still used "Faithful Answers" and called the
  Docker build standalone.
- The 301 review's placement section read as current; it is now past
  tense and points to the later rename.
- The app README, two test comments and .dockerignore still mentioned
  the removed standalone verification copy, an app-local lockfile, or
  "both" service images.

Comments and prose only; no behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@yia-mw-agent yia-mw-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full merge-base-to-head diff (base codex/ansari-faithful-answers-076 at 07bdfb1, head 65112f6, 7 files, +10/-11, prose and comments only). No material defects.

Checked:

  • The new "all three images (api, auth, mcp) build from the repo root" wording in codev/resources/arch.md matches the code. apps/mcp/Dockerfile uses WORKDIR /repo and copies the root lockfile and packages, as the api and auth Dockerfiles do.
  • The 301 review's "later renamed apps/mcp" and "PR iaser-ai#323 repairs moved the Docker context to the repository root" statements match the existing "PR iaser-ai#323 review repairs (0.16.6)" section in the same file.
  • The README heading and Docker wording, the .dockerignore comment, the apps/mcp/README.md and the two test comments are accurate, with no stray references to the removed "standalone verification copy".
  • No behaviour or code paths are changed, so no version bump is correct.

Validation on the exact head: pnpm install --frozen-lockfile --filter ansari-mcp..., pnpm mcp build and build:worker succeed. copy-boundary.test.ts and packaging.test.ts pass 9 of 9, and eslint in apps/mcp is clean.

Non-blocking: the 301-* spec, plan and review filenames keep the old name, which the PR description says is deliberate.

Helmet-Review-Request: #4 (comment)

@timeleft--
timeleft-- merged commit 822c1cf into codex/ansari-faithful-answers-076 Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants