Repository navigation
docs(mcp): refresh the walkthrough and add a Why SAGA chapter - #5
timeleft-- merged 3 commits into
Conversation
The walkthrough's source links pointed at the app 0.16.5 / SAGA 0.7.6-rc.1 commit under the old apps/ansari-faithful-answers path, where five linked files differ from the embedded copies and third-party-licences.ts is absent. They now point at apps/mcp at 822c1cf, whose files match the embedded sources byte for byte. The Assets and licenses notice now carries the MIT artwork grant from assets/NOTICE.md and says SAGA's notices travel in the card HTML. Also fix a typo, and drop the README's mention of a hosted lifecycle addendum the walkthrough no longer contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
left a comment
There was a problem hiding this comment.
Reviewed the full merge-base-to-head diff (base codex/ansari-faithful-answers-076 at 822c1cf, head cd4d1f3, two files, +11/-10). No material defects.
Checked:
- SOURCE_BASE now points at MachineWisdomAI/ansari, commit 822c1cf, apps/mcp/. That commit is the PR base, and all 17 files in the embedded
sourcesmap are byte-identical to apps/mcp/ there, including scripts/third-party-licences.ts. - The licence block in the footer matches the opening of apps/mcp/assets/NOTICE.md exactly (copyright line, MIT grant, SAGA/OFL sentence), apart from the OFL text the page already carried. LICENSE at the repo root is MIT, so the relative link text is accurate.
- The "records" typo fix and the README sentence removal are correct. No references to 8b5da23, the old apps/ansari-faithful-answers path, or a hosted lifecycle addendum remain in either file.
- Nothing else in the repo references the walkthrough, so there is no downstream breakage. Docs only, so no version bump is needed.
Non-blocking: when I submitted, the api, auth and MCP application checks were still in progress. frontend and gitleaks had passed. The diff touches neither code nor tests. The page was not rendered in a browser, which the PR description also notes.
Helmet-Review-Request: #5 (comment)
The placement section says the walkthrough keeps its source links at the original revision. Record in the repairs section that they now point at apps/mcp at 822c1cf, along with the MIT artwork notice. Head the opening section as the original contribution, since its standalone-CI account predates the review repairs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
left a comment
There was a problem hiding this comment.
Helmet-Review-Request: #5 (comment)
Reviewed the full merge-base-to-head diff (base codex/ansari-faithful-answers-076 at merge-base 822c1cf, head 571e838; 3 docs files, +16/-10). The live head matched the selected head when I started and again before submitting.
Checked:
SOURCE_BASEnow points atMachineWisdomAI/ansariapps/mcp/at822c1cf. That commit exists in the repository. No8b5da23,apps/ansari-faithful-answers/ortimeleft--reference remains in the page.- All 17 embedded source files in the walkthrough data are byte-identical to
apps/mcp/<file>at the PR head. I compared them programmatically. - The "Assets and licenses" dialog opens with the same text as
apps/mcp/assets/NOTICE.md, including the MIT grant and the revised SAGA/OFL sentence. The OFL text that follows is unchanged. The "record" to "records" typo is fixed. - The README sentence about a hosted lifecycle addendum is removed. The page has no such section, and nothing else references that sentence.
- The
codev/reviews/301-faithful-answers-mcp.mdadditions are consistent with the diff. The new "Original contribution" heading and the blank line before the next heading are cosmetic. - Docs only, with no code or version change. The one script change swaps a string constant.
No material defects.
Non-blocking:
- The dialog text repeats the
[MIT licence](../../../LICENSE)Markdown link from NOTICE.md inside a<pre>, so it shows as literal text and not as a working link. This matches the source notice and is harmless. - The PR says the page was not rendered in a browser, so I did not render it either. Given the change size, I do not consider that blocking.
A seventh chapter explains why the app builds on SAGA rather than directly on the MCP Apps SDK: A2UI's published binding contract, FaithfulCard as a complete answer component, and a view that never touches MCP Apps' two-sided App/AppBridge API. It gives the rough code estimate for a direct build and what Ansari still owns. The tab grid widens to seven columns on desktop; narrower layouts already wrap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
left a comment
There was a problem hiding this comment.
Helmet-Review-Request: #5 (comment)
Reviewed the full merge-base (822c1cf) to head (6a1ba66) diff against codex/ansari-faithful-answers-076: 3 files, docs only (README, walkthrough HTML, 301 review). No material defects.
Checked:
- All 17 sources embedded in the walkthrough are byte-identical to
apps/mcp/at the head, andSOURCE_BASEnow points atMachineWisdomAI/ansariat822c1cfunderapps/mcp/. No8b5da23,apps/ansari-faithful-answers/orrecord itstext remains. The embedded JSON parses. - The licence dialog text matches
apps/mcp/assets/NOTICE.md, which this PR does not change, so the packaging test that compares the notice with the built artifact is unaffected. The rootLICENSEis MIT. - Why SAGA chapter: the tab and panel IDs and ARIA wiring are consistent. The tab script is generic over all tabs, so arrow keys wrap across seven. The CSS media rules scope the 7-column layout to wide screens. The four external links return HTTP 200.
apps/mcp/srccontains noext-appsimport, as claimed (it is a devDependency only). The app source is 1,394 lines across 25 files, matching the text. The estimate is labelled as unmeasured. - The README sentence no longer describes the missing lifecycle addendum. The 301 review additions are consistent with the PR description.
- No runtime, source or test files are touched, so I did not rerun the install-dependent suites.
Non-blocking: none.
052fbaf
into
codex/ansari-faithful-answers-076
Repairs the stale parts of
apps/mcp/docs/show-me-ansari-mcp.htmlfound while checking it against the PR head (822c1cf) for iaser-ai#323.Changes
8b5da23(app 0.16.5 on SAGA 0.7.6-rc.1) under the oldapps/ansari-faithful-answers/path. Five of the linked files differ there from the copies the page embeds, andscripts/third-party-licences.tsdoesn't exist there. They now point atapps/mcp/at822c1cf.apps/mcp/assets/NOTICE.md, and says that SAGA's licence and third-party notices are retained in the distributed card HTML.apps/mcp/README.mdsentence describing a hosted lifecycle addendum. The walkthrough hasn't contained one since8b5da23.codev/reviews/301-faithful-answers-mcp.mdrecords the link and notice update in its PR feat: add Ansari MCP app with stable saga a2ui 0.7.6 iaser-ai/ansari#323 repairs section. The section about the workspace move still says the walkthrough keeps its original links. The opening section now has an "Original contribution" heading, since it describes CI before the review repairs.Everything else on the page already matched the head: all 17 embedded source files and every excerpt are byte-identical to
822c1cf, and the stated versions, commands, limits and environments are correct. Lint is already applied:eslint . --fixchanges no file, so the linked sources are stable.App/AppBridgeAPI out of Ansari's code (Ansari's source imports nothing from@modelcontextprotocol/ext-apps). It also gives the rough estimate for a direct build (about 750–1,850 more lines, tests excluded, nothing built to measure it) and lists what Ansari still owns. The README's description of the walkthrough mentions the new chapter.Validation
822c1cf: 142 of 142 server/packaging tests and 73 of 73 browser checks pass, and all 1,669 lockfile snapshots match137c96a.Docs only, so no version bump.
🤖 Generated with Claude Code