Repository navigation
feat(mcp): add the ChatGPT publication input with Ansari's icon - #8
Open
timeleft-- wants to merge 1 commit into
Open
timeleft-- wants to merge 1 commit into
timeleft-- wants to merge 1 commit into
Conversation
Add saga-publication.json, the release input SAGA's saga publish tool uses to prepare the ChatGPT plugin package. It names Ansari's listing, the Dev endpoint and the build, and points both the logo and the composer icon at assets/ansari-plugin-icon.svg: the unchanged floral mark from brand-mark.ts on the card's green. Supplying both keeps SAGA's default artwork out of Ansari's package. The release gate's version mirror moves from a plugin/plugin.json this repository never had to the release input, and also requires its endpoint.expectedServer.version to match the app version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
approved these changes
Oct 29, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full merge-base-to-head diff (base develop, merge-base 3a072da, head b75a3cc, 5 files, +75/-17). No material defects.
Helmet-Review-Request: #8 (comment)
What I checked
- Release gate (apps/mcp/scripts/check-release.mjs):
RELEASE_FILES,RELEASE_CONTENTandvalidateReleasenow point atapps/mcp/saga-publication.json. The release-files screen blanks bothversionandendpoint.expectedServer.version, andvalidateReleasecompares both against package.json. No reference to the oldplugin/plugin.jsonremains anywhere in the repo. - Tests (apps/mcp/test/release.test.ts): the fixtures and assertions are updated to match, including the new
expectedServer.versionmismatch case. The "beyond the release version" check still exercises a changed publication file. - Icon (apps/mcp/assets/ansari-plugin-icon.svg): parses as valid XML. Its nine paths are identical to those in the embedded
brand-mark.ts. It sits on a#15583erounded rect, matching the card's mark surface. - saga-publication.json: valid JSON. Version 0.16.6 matches package.json and the expected server.
assets.logoandassets.composerIconboth resolve to the committed SVG, andbuildpoints atdist/view.html, which the build actually produces. - README: the new section matches the input and the gate's behaviour.
Validation (from the head checkout, apps/mcp): pnpm lint and pnpm typecheck pass. pnpm build and pnpm build:worker succeed. pnpm test passes 142/142. node scripts/check-release.mjs --target dev passes. I did not run the SAGA publish prepare tool or the browser tests, and did not contact the Dev endpoint; the PR description states the two known saga publish findings (Dev still serving the older build, and destructiveHint left unset by design).
Non-blocking
- The comment in check-release.mjs still says "the three small release files" while
RELEASE_FILEShas four entries (this predates the PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to iaser-ai#323, now merged. It brings the plugin icon from MachineWisdomAI/ansari-faithful-answers#105 to the MCP app, using SAGA's
saga publishtool instead of a hand-writtenplugin/folder.This replaces #6. It's the same commit (
e632702), rebased ontodevelopat3a072da, which merged iaser-ai#323. A new branch avoids force-pushing #6's. Until #7 brings this fork'sdevelopup to3a072da, the diff here also shows iaser-ai#323's commits.Changes
apps/mcp/saga-publication.json. The release inputsaga publish prepare --target chatgptreads.ansari-mcp0.16.6.dist/view.html.apps/mcp/assets/ansari-plugin-icon.svg. The nine paths fromassets/brand-mark.ts, unchanged, on the card's#15583egreen rounded square, with the same bytes as chore(porch): 100 complete iaser-ai/ansari#105's icon. Bothassets.logoandassets.composerIconpoint at it. With feat: default prepared ChatGPT plugins to SAGA branding saga-a2ui#339, a missing field falls back to the SAGA seahorse, so Ansari has to supply both.plugin/plugin.json, a file this repository never had. It now checks the release input'sversionandendpoint.expectedServer.versionagainstpackage.json. The release-files screen blanks both of those fields.The artwork notice is unchanged: the icon is the MIT-licensed attribution mark that
assets/NOTICE.mdalready covers.Validation
saga publish prepare --target chatgptat saga-a2ui#339's head (54b8cab), against the Dev endpoint. The input, discovery, identity (ansari-mcp0.16.6), manifest, MCP config, listing, assets, components and secrets checks all pass. "The logo and composer icon are present, square, valid and within the size limits."assemblePackageon this input:plugin.json,mcp.jsonandassets/ansari-plugin-icon.svg, byte-identical to the committed file. There's no SAGA seahorse.interface.logoandinterface.composerIconare both./assets/ansari-plugin-icon.svg.endpoint.views: Dev still serves thefc40c24build, not this one. Preparing a package needs Dev redeployed from this branch.endpoint.tools: the ChatGPT plugin guidelines wantdestructiveHintset explicitly. The tool keeps the legacy server'sreadOnlyHintandopenWorldHintonly, as Amr's parity item asked. Keeping them was decided on October 29, 2026.3a072da+ this commit: lint, typecheck, Node and Worker builds, and 142/142 tests (release tests 32/32).check-release --target devpasses. With the input's version set to 0.16.5 it fails with "saga-publication.json version (0.16.5) differs".Nothing was deployed, uploaded or submitted.
🤖 Generated with Claude Code