refactor: config and new rate limit vars

Author: Maikuh

AGENTS.md

@@ -68,6 +68,8 @@ In-memory `Map`. Key = SHA-256(normalized query params). TTL = `CACHE_TTL` env (
 | `LRCLIB_API_BASE` | `https://lrclib.net/api` | |
 | `ADMIN_KEY` | — | Required for admin cache endpoints |
 | `CACHE_TTL` | `86400` | Seconds |
+| `RATE_LIMIT_MAX` | `15` | Max requests per window; set both to `0` to disable |
+| `RATE_LIMIT_DURATION` | `60000` | Window duration in ms |
 | `NODE_ENV` | — | `production` disables pino-pretty |
 
 ## Key files

src/fetcher.ts

@@ -17,8 +17,8 @@ const DEFAULT_PLAIN_SEQUENCE = [
 ]
 const FAST_MODE_SEQUENCE = ['lrclib', 'simpmusic']
 
-if (config.geniusToken) DEFAULT_PLAIN_SEQUENCE.push('genius')
-if (config.mxmEnabled) {
+if (config.genius.token) DEFAULT_PLAIN_SEQUENCE.push('genius')
+if (config.mxm.enabled) {
 	DEFAULT_PLAIN_SEQUENCE.push('mxm')
 	FAST_MODE_SEQUENCE.push('mxm')
 }

src/index.ts

@@ -47,8 +47,9 @@ const app = new Elysia()
 	.use(cors())
 	.use(
 		rateLimit({
-			max: 15,
-			duration: 60_000,
+			max: config.rateLimit.max,
+			duration: config.rateLimit.duration,
+			skip: config.rateLimit.enabled ? undefined : () => true,
 			errorResponse: new Response(
 				JSON.stringify({
 					error: { message: 'Too many requests', timestamp: timestamp() },

src/lib/cache.ts

@@ -45,7 +45,7 @@ export function loadFromCache(key: string): unknown | null {
 }
 
 export function saveToCache(key: string, result: unknown): void {
-	store.set(key, { expiry: Date.now() / 1000 + config.cacheTtl, result })
+	store.set(key, { expiry: Date.now() / 1000 + config.cache.ttl, result })
 }
 
 export function clearCache(): { removed: number } {
@@ -57,7 +57,7 @@ export function clearCache(): { removed: number } {
 export function cacheStats() {
 	return {
 		cache_keys: store.size,
-		ttl_seconds: config.cacheTtl,
+		ttl_seconds: config.cache.ttl,
 		version: CACHE_VERSION,
 	}
 }

src/lib/config.ts

@@ -1,9 +1,26 @@
 export const config = {
 	port: Number(process.env.PORT ?? 4000),
 	logLevel: (process.env.LOG_LEVEL ?? 'INFO').toUpperCase(),
-	adminKey: process.env.ADMIN_KEY ?? '',
-	geniusToken: process.env.GENIUS_TOKEN ?? '',
-	lrclibApiBase: process.env.LRCLIB_API_BASE ?? 'https://lrclib.net/api',
-	cacheTtl: Number(process.env.CACHE_TTL ?? 86400),
-	mxmEnabled: (process.env.MXM_ENABLED ?? 'true').toLowerCase() !== 'false',
+	admin: {
+		key: process.env.ADMIN_KEY ?? '',
+	},
+	genius: {
+		token: process.env.GENIUS_TOKEN ?? '',
+	},
+	lrclib: {
+		apiBase: process.env.LRCLIB_API_BASE ?? 'https://lrclib.net/api',
+	},
+	cache: {
+		ttl: Number(process.env.CACHE_TTL ?? 86400),
+	},
+	mxm: {
+		enabled: (process.env.MXM_ENABLED ?? 'true').toLowerCase() !== 'false',
+	},
+	rateLimit: {
+		max: Number(process.env.RATE_LIMIT_MAX ?? 15),
+		duration: Number(process.env.RATE_LIMIT_DURATION ?? 60_000),
+		get enabled() {
+			return this.max !== 0 || this.duration !== 0
+		},
+	},
 }

src/routes/cache.ts

@@ -11,13 +11,13 @@ import { CacheStats } from '../lib/schemas'
 const logger = getLogger('cache')
 
 function checkAdmin(request: Request, queryKey?: string): boolean {
-	if (!config.adminKey) return false
+	if (!config.admin.key) return false
 	const provided = queryKey ?? request.headers.get('x-admin-key') ?? ''
 	if (!provided) return false
 	try {
-		const a = Buffer.from(config.adminKey.padEnd(64).slice(0, 64))
+		const a = Buffer.from(config.admin.key.padEnd(64).slice(0, 64))
 		const b = Buffer.from(provided.padEnd(64).slice(0, 64))
-		return timingSafeEqual(a, b) && provided === config.adminKey
+		return timingSafeEqual(a, b) && provided === config.admin.key
 	} catch {
 		return false
 	}

src/sources/genius.ts

@@ -17,14 +17,14 @@ export const geniusFetcher = defineFetcher({
 	source: 'genius',
 	displayName: 'Genius',
 	async run(artist, song, _timestamps, signal): Promise<LyricResult | null> {
-		if (!config.geniusToken) {
+		if (!config.genius.token) {
 			logger.info('Genius token not configured — skipping')
 			return null
 		}
 
 		const searchRes = await httpGet(
 			`https://api.genius.com/search?q=${encodeURIComponent(`${song} ${artist}`)}`,
-			{ headers: { Authorization: `Bearer ${config.geniusToken}` }, signal },
+			{ headers: { Authorization: `Bearer ${config.genius.token}` }, signal },
 		)
 		if (!searchRes.ok) return null
 

src/sources/lrclib.ts

@@ -32,7 +32,7 @@ async function lrclibGet(
 	track: Record<string, unknown>,
 	signal?: AbortSignal,
 ): Promise<Record<string, unknown> | null> {
-	const url = new URL(`${config.lrclibApiBase}/get`)
+	const url = new URL(`${config.lrclib.apiBase}/get`)
 	if (track.trackName) url.searchParams.set('track_name', String(track.trackName))
 	if (track.artistName) url.searchParams.set('artist_name', String(track.artistName))
 	if (track.albumName) url.searchParams.set('album_name', String(track.albumName))

src/sources/mxm.ts

@@ -195,7 +195,7 @@ export const mxmFetcher = defineFetcher({
 	source: 'mxm',
 	displayName: 'Musixmatch',
 	async run(artist, song, timestamps, signal): Promise<LyricResult | null> {
-		if (!config.mxmEnabled) return null
+		if (!config.mxm.enabled) return null
 
 		const state = await getToken(signal)