fix(discovery): Improve local network permission handling

Enhances server discovery by explicitly checking for local network permission, preventing discovery attempts when permission is not granted, and updating the UI accordingly. This ensures a smoother user experience and proper permission adherence.

Key changes:
* Permission Check for Discovery: Local and broadcast server discovery now explicitly checks if local network permission is satisfied before initiating.
* UI State Update: The login UI state is updated to reflect when local network permission is required, guiding the user.
* Resume Permission Recheck: Added a mechanism to recheck local network permission when the login screen resumes, automatically triggering discovery if permission is granted.
* Broadcast Discovery Timeout: Introduced a timeout for broadcast server discovery to prevent indefinite waits.

Author: MakD

app/src/main/java/com/makd/afinity/data/discovery/LocalServiceDiscovery.kt

@@ -73,6 +73,11 @@ constructor(
         serviceType: String,
         timeoutMs: Long = DEFAULT_TIMEOUT_MS,
     ): Flow<DiscoveryResult> {
+        if (!localNetworkPermission.isSatisfied()) {
+            Timber.d("mDNS: local network permission not granted, skipping $serviceType")
+            return flowOf(DiscoveryResult.PermissionRequired)
+        }
+
         val manager =
             nsdManager
                 ?: run {

app/src/main/java/com/makd/afinity/data/repository/server/JellyfinServerRepository.kt

@@ -268,24 +268,29 @@ constructor(
             }
         }
 
-        launch {
-            try {
-                jellyfin.discovery.discoverLocalServers(timeout = 5000, maxServers = 10).collect {
-                    serverInfo ->
-                    addServer(
-                        Server(
-                            id = serverInfo.id,
-                            name = serverInfo.name,
-                            version = null,
-                            address = serverInfo.address,
-                        ),
-                        "broadcast",
-                    )
+        if (localNetworkPermission.isSatisfied()) {
+            launch {
+                try {
+                    withTimeoutOrNull(BROADCAST_DISCOVERY_TIMEOUT_MS.milliseconds) {
+                        jellyfin.discovery
+                            .discoverLocalServers(timeout = 5000, maxServers = 10)
+                            .collect { serverInfo ->
+                                addServer(
+                                    Server(
+                                        id = serverInfo.id,
+                                        name = serverInfo.name,
+                                        version = null,
+                                        address = serverInfo.address,
+                                    ),
+                                    "broadcast",
+                                )
+                            }
+                    }
+                } catch (e: CancellationException) {
+                    throw e
+                } catch (e: Exception) {
+                    Timber.e(e, "Broadcast server discovery failed")
                 }
-            } catch (e: CancellationException) {
-                throw e
-            } catch (e: Exception) {
-                Timber.e(e, "Broadcast server discovery failed")
             }
         }
 
@@ -511,5 +516,6 @@ constructor(
         const val RECONNECT_INITIAL_DELAY_MS = 2_000L
         const val RECONNECT_MAX_DELAY_MS = 120_000L
         const val UNREACHABLE_CONFIRM_DELAY_MS = 4_000L
+        const val BROADCAST_DISCOVERY_TIMEOUT_MS = 5_000L
     }
 }

app/src/main/java/com/makd/afinity/ui/login/LoginScreen.kt

@@ -85,6 +85,7 @@ import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
+import androidx.lifecycle.compose.LifecycleResumeEffect
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import coil3.compose.AsyncImage
 import coil3.request.ImageRequest
@@ -139,6 +140,11 @@ fun LoginScreen(
 
     LaunchedEffect(Unit) { viewModel.discoverServers() }
 
+    LifecycleResumeEffect(Unit) {
+        viewModel.recheckLocalNetworkPermission()
+        onPauseOrDispose {}
+    }
+
     LaunchedEffect(loginState.uiState.isLoggedIn) {
         if (loginState.uiState.isLoggedIn) {
             onLoginSuccess()

app/src/main/java/com/makd/afinity/ui/login/LoginViewModel.kt

@@ -686,8 +686,23 @@ constructor(
         discoverServers()
     }
 
+    fun recheckLocalNetworkPermission() {
+        if (_uiState.value.needsLocalNetworkPermission && localNetworkPermission.isSatisfied()) {
+            onLocalNetworkPermissionGranted()
+        }
+    }
+
     fun discoverServers() {
         discoveryJob?.cancel()
+        if (!localNetworkPermission.isSatisfied()) {
+            _uiState.value =
+                _uiState.value.copy(
+                    isDiscovering = false,
+                    discoveredServers = emptyList(),
+                    needsLocalNetworkPermission = true,
+                )
+            return
+        }
         discoveryJob = viewModelScope.launch {
             _uiState.value =
                 _uiState.value.copy(