"IgnoreIf" doesn't work for records

[MaximBusyrev]

Hi. In version 10.0.11, "IgnoreIf" doesn't work as it did in version 7... My mapper is written like this:

.Map(ask => ask.BoxPost, crm => crm.GetValue<AddressEntity, string?>(nameof(AddressEntity.BoxPost)))
.IgnoreIf((d, ask) => !d.ContainsKey<AddressEntity>(nameof(AddressEntity.BoxPost)), nameof(AddressEntity.BoxPost))

previously, in version 7, the following mapper code was generated:

.If (
    .Call ReForm.Ism.Core.Serialization.Extensions.JsonObjectExtension.ContainsKey(
        $var1,
        "BoxPost")
) {
    .Block() {
        $result.BoxPost = .Invoke (.Lambda #Lambda2<System.Func`3[System.String,System.Nullable`1[System.Decimal],System.Nullable`1[System.Decimal]]>)(
.Call ReForm.Ism.Core.Serialization.Extensions.JsonObjectExtension.GetValue(
    $var1,
    "BoxPost"),
$result.BoxPost)
    }
} .Else {
    .Default(System.Void)
};

and now I get this:

BoxPost = .Invoke (.Lambda #Lambda2<System.Func`2[System.String,System.Nullable`1[System.Decimal]]>)(.Call ReForm.Ism.Core.Serialization.Extensions.JsonObjectExtension.GetValue(
                    $var1,
                    "BoxPost")),

It turns out that the presence of "IgnoreIf" does not change anything.

[DocSvartz]

HI @MaximBusyrev, destination type is record ?

[MaximBusyrev]

@DocSvartz source and destination is records

[alihut]

I found the root cause and opened a fix: #1008

It's specific to record types where the ignored member is a settable property outside the primary constructor (e.g. BoxPost added as a plain { get; set; } rather than a constructor parameter) — RecordTypeAdapter.RecordInlineExpression was building the MemberInit binding without ever checking the IgnoreIf condition. Details and a minimal repro are in the PR description.

[DocSvartz]

@MaximBusyrev @alihut
IgnoreIF() is not supported for record type in version 7.4.0 and version 10.

@alihut Thanks, it fix This fix has been added in the new version.
But it still won't work quite the same way as mutable types (handled by ClassAdapter).
For mutable types:

1. IgnoreIF() applied IgnoreNullValues(true) if it is installed
2. For each property, more than one IgnoreIf() can be set. I may be wrong, But that's exactly how it looks.;

Most likely, there will already be certain changes related to this in version 10.1.