Address review comments

Author: RazvanLiviuVarzaru

master-libvirt/master.cfg

@@ -267,9 +267,6 @@ for builder_name in BUILDERS_INSTALL:
             properties={
                 "systemdCapability": "yes",
                 "needsGalera": "yes",
-                "dist_name": os_name,
-                "version_name": OS_INFO[os_info_name]["version_name"],
-                "arch": build_arch,
                 "test_mode": "server",
                 "test_type": "distro",
                 "BB_CI": True,

scripts/bash_lib.sh

@@ -244,7 +244,7 @@ deb_setup_mariadb_mirror() {
     exit 1
   }
   [[ $1 == "N/A" ]] && {
-    bb_log_warn "performing a distribution upgrade, skipping repository setup"
+    bb_log_info "performing a distribution upgrade, skipping repository setup"
     set +u
     return 0
   }
@@ -254,7 +254,7 @@ deb_setup_mariadb_mirror() {
     bb_log_err "wget command not found"
     exit 1
   }
-  #//TEMP it's probably better to install the last stable release here...?
+
   source /etc/os-release
 
   if [ "${PRETTY_NAME##*/}" == "sid" ]; then

scripts/deb-upgrade.sh

@@ -25,6 +25,12 @@ bb_print_env
 # - 'deps'   -- only a limited set of main packages is installed and upgraded,
 #               to make sure upgrade does not require new dependencies
 # - 'columnstore' -- mariadb-server and mariadb-plugin-columnstore are installed
+
+# And there are three upgrade types:
+# - 'minor' -- upgrade within the same major version, e.g. 10.5.x to 10.5.y
+# - 'major' -- upgrade to the next major version, e.g. 10.x to 10.y
+# - 'distro' -- upgrade from the version provided by the distro
+
 bb_log_info "Current test mode: $test_mode"
 
 set -x