Skip to content

MDBF 1102 - Implement deb upgrade from distro default - #826

Merged
RazvanLiviuVarzaru merged 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1102
Aug 28, 2025
Merged

MDBF 1102 - Implement deb upgrade from distro default#826
RazvanLiviuVarzaru merged 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1102

Conversation

@RazvanLiviuVarzaru

@RazvanLiviuVarzaru RazvanLiviuVarzaru commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Introduce the distro test_type to bash_lib.
In distro mode prev_major_version is set to
a non-existent value so that mirror setup is skipped.

In buildbot, a new type of libvirt builder is defined, ending in -distro-upgrade

@RazvanLiviuVarzaru
RazvanLiviuVarzaru force-pushed the MDBF-1102 branch 4 times, most recently from b55b5f7 to a85aeee Compare August 27, 2025 07:19
@RazvanLiviuVarzaru RazvanLiviuVarzaru changed the title tmp - distro upgrade deb/ubu MDBF 1102 - Implement deb upgrade from distro default Aug 27, 2025
@RazvanLiviuVarzaru
RazvanLiviuVarzaru marked this pull request as ready for review August 27, 2025 07:21
fauust
fauust reviewed Aug 27, 2025
View reviewed changes

@fauust fauust left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very nice improvement IMO, more coverage for real life scenario. Good!
Small comment below.

Comment thread scripts/bash_lib.sh Outdated
grooverdan
grooverdan approved these changes Aug 28, 2025
View reviewed changes

@grooverdan grooverdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions otherwise good.

The deb/rpm-upgrade.sh scripts verbosely list the the 4 types of upgrade which is now 5. So recommend moving/removing or updating those too.

Comment thread master-libvirt/master.cfg Outdated
Comment thread scripts/bash_lib.sh Outdated
Comment thread scripts/bash_lib.sh
Comment thread utils.py
@RazvanLiviuVarzaru

RazvanLiviuVarzaru commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator Author

minor suggestions otherwise good.

The deb/rpm-upgrade.sh scripts verbosely list the the 4 types of upgrade which is now 5. So recommend moving/removing or updating those too.

Do you mean this?

# This test can be performed in four modes:
# - 'server' -- only mariadb-server is installed (with whatever dependencies it pulls) and upgraded.
# - 'all'    -- all provided packages are installed and upgraded, except for Columnstore
# - 'deps'   -- only a limited set of main packages is installed and upgraded,
#               to make sure upgrade does not require new dependencies
# - 'columnstore' -- mariadb-server and mariadb-plugin-columnstore are installed

@RazvanLiviuVarzaru
MDBF 1102 - Implement deb upgrade from distro default
e600ba4 
Introduce the `distro` test_type to bash_lib.
In `distro` mode `prev_major_version` is set to
a non-existent value so that mirror setup is skipped.

In buildbot, a new type of libvirt builder is defined, ending in `-distro-upgrade`
@RazvanLiviuVarzaru
RazvanLiviuVarzaru merged commit 468ba1d into MariaDB:dev Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grooverdan grooverdan grooverdan approved these changes
@fauust fauust fauust approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RazvanLiviuVarzaru @grooverdan @fauust