MDBF-1121 - libvirt - RPM automatic upgrades - #841
Conversation
As per MDEV-33459, major upgrades within the same family (>10) and vendor (!=distro) should work without removing old packages first.
237ccf0 to
5baff6e
Compare
|
|
||
| old_family=$(echo "$prev_major_version" | sed -n -e 's,^\([1-9][0-9]*\)\..*$,\1,p') | ||
| new_family=$(echo "$major_version" | sed -n -e 's,^\([1-9][0-9]*\)\..*$,\1,p') | ||
|
|
There was a problem hiding this comment.
so this is extracting before the .?
so ${prev_major_version%%.*} is the same right?
There was a problem hiding this comment.
Yes, I used the same rule as in MDEV-33459 commit.
That happens to match the number before ..
|
|
||
| if [[ "$test_type" == "distro" || | ||
| ( "$old_family" -lt 11 && "$test_type" != "minor" ) || | ||
| "$old_family" -ne "$new_family" ]]; then |
There was a problem hiding this comment.
I think this is MDEV-9584 so it might be that the server upgrade needs to allow 11 -> 12 without removal first.
There was a problem hiding this comment.
I tested 11 -> 12. It does not work.
Have a look at: https://github.com/MariaDB/server/blob/main/support-files/rpm/server-prein.sh
There was a problem hiding this comment.
In any case, the scope of this MDBF is to align the two buildbots.
Further scenarios are welcome and to be treated separately.
There was a problem hiding this comment.
Yes - the prein.sh is the bit of dated stuff that probably should be removed. as separate task.
As per MDEV-33459, major upgrades within the same family (>10) and vendor (!=distro) should work without removing old packages first.