Skip to content

MDBF-1121 - libvirt - RPM automatic upgrades - #841

Merged
RazvanLiviuVarzaru merged 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1121
Sep 15, 2025
Merged

MDBF-1121 - libvirt - RPM automatic upgrades#841
RazvanLiviuVarzaru merged 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1121

Conversation

@RazvanLiviuVarzaru

Copy link
Copy Markdown
Collaborator

As per MDEV-33459, major upgrades within the same family (>10) and vendor (!=distro) should work without removing old packages first.

As per MDEV-33459, major upgrades within the same family (>10) and vendor (!=distro)
should work without removing old packages first.
Comment thread scripts/rpm-upgrade.sh

old_family=$(echo "$prev_major_version" | sed -n -e 's,^\([1-9][0-9]*\)\..*$,\1,p')
new_family=$(echo "$major_version" | sed -n -e 's,^\([1-9][0-9]*\)\..*$,\1,p')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is extracting before the .?

so ${prev_major_version%%.*} is the same right?

@RazvanLiviuVarzaru RazvanLiviuVarzaru Sep 15, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I used the same rule as in MDEV-33459 commit.
That happens to match the number before ..

Comment thread scripts/rpm-upgrade.sh

if [[ "$test_type" == "distro" ||
( "$old_family" -lt 11 && "$test_type" != "minor" ) ||
"$old_family" -ne "$new_family" ]]; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is MDEV-9584 so it might be that the server upgrade needs to allow 11 -> 12 without removal first.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested 11 -> 12. It does not work.
Have a look at: https://github.com/MariaDB/server/blob/main/support-files/rpm/server-prein.sh

@RazvanLiviuVarzaru RazvanLiviuVarzaru Sep 15, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, the scope of this MDBF is to align the two buildbots.
Further scenarios are welcome and to be treated separately.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - the prein.sh is the bit of dated stuff that probably should be removed. as separate task.

@RazvanLiviuVarzaru
RazvanLiviuVarzaru merged commit a48b17a into MariaDB:dev Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants