MDEV-39806: Add a per-push/per-pull-request checker for Markdown API docs - #5153
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
c0b255a to
538d427
Compare
vuvova
left a comment
There was a problem hiding this comment.
I never created or maintained github actions so I cannot really review that.
Commands under run look ok (if I'm not going to nitpick)
RazvanLiviuVarzaru
left a comment
There was a problem hiding this comment.
As I remember from our previous discussions,
the main idea was that in the server repository to only have a Pull Request check action, that will fail for any documentation errors. assuming that you configured the tool to fail the action when there's a legitimate error on docs.
Did I missed something in the meantime?
vuvova
left a comment
There was a problem hiding this comment.
agree with @RazvanLiviuVarzaru, my recollection also is that we agreed that cmake and other build prerequisites aren't required to generated documentation
538d427 to
d185611
Compare
I was hoping to get #5112 merged first, but it seems like we'll be doing the two in parallel. OK. I've updated the PR with code that's based on the files in #5112. |
|
Note that we will need to also update the moxygen version in mariadb-doc-gen: there are some fixes in it that are needed: https://github.com/sourcey/moxygen/releases/tag/v2.1.12 |
bec8321 to
6b67b71
Compare
RazvanLiviuVarzaru
left a comment
There was a problem hiding this comment.
@gkodinov review submitted.
Please, if you do any updates,
1 minute after any push, go-to https://buildbot.mariadb.org/#/builders/1
and cancel your run. No need for bb ci to run tests for this patch.
6b67b71 to
e6e2925
Compare
…docs Create a GitHub action into the MariaDB server tree to build the Markdown documentation using the cmake target provided by MDEV-39718. This workflow generates API documentation for the plugin using a Docker container packed with all the extra doxygen/moxygen tools. Fixed some more doxygen problems. Moved the repo to ghcr.io/mariadb/mariadb-doc-gen:latest.
e6e2925 to
aecd06f
Compare
|
FWIW, this is how the docker image used is generated: Put the above in a Dockerfile in the current dir and then run command: |
Create a GitHub action into the MariaDB server tree to build the Markdown documentation using the cmake target provided by MDEV-39718.
This workflow generates API documentation for the plugin using a Docker container packed with all the extra doxygen/moxygen tools and the latest CMake dependencies.