MDEV-40553: unprintable gis ranges in trace and context - #5493
Open
bsrikanth-mariadb wants to merge 1 commit into
Conversation
bsrikanth-mariadb
force-pushed
the
13.2-MDEV-40553-unprintable_gis-ranges-in-trace-and-context
branch
3 times, most recently
from
August 7, 2026 10:59
0bb4fe0 to
a5a2383
Compare
Member
|
Please apply this cleanup patch. Please fix typos in the commit comment: "MDRWITHIN, MDRCONTAINS"... |
bsrikanth-mariadb
force-pushed
the
13.2-MDEV-40553-unprintable_gis-ranges-in-trace-and-context
branch
2 times, most recently
from
August 11, 2026 02:47
b179003 to
100e08c
Compare
Member
|
Please remove Field_geom::print_key_value(). I think it is not a good idea to print geometry values. When the lookups are done, binary values are interpreted as BINARY(n) values and so should be printed as such. However their binary representation is not identical: |
bsrikanth-mariadb
force-pushed
the
13.2-MDEV-40553-unprintable_gis-ranges-in-trace-and-context
branch
from
August 11, 2026 16:06
100e08c to
b642aee
Compare
bsrikanth-mariadb
force-pushed
the
13.2-MDEV-40553-unprintable_gis-ranges-in-trace-and-context
branch
2 times, most recently
from
September 1, 2026 07:19
6dae511 to
0598525
Compare
When ranges were specified in a query for GIS types, the recorded trace and context couldn't print the range information. Instead, it only showed unprintable_geometry_value. This PR extends the geometric field type Field_geom to print key value in binary form (same as what is done for Blobs today), along with the comparison operator, when recorded in the range. For spatial indexes, the operators like MBRWITHIN, MBRCONTAINS, etc... are stored appropriately, and for normal indexes, operators like <, <=, >, >=, etc... are recorded appropriately. Implementation Details: - Add an argument imagetype to Field::print_key_part_value(), to determine if an index key part value is to be printed in WKT or binary format. For Geometric type, imagetype is set to itMBR. When printing ranges, the MBR operators are printed as well, as implemented in print_mbr_range_operator().
bsrikanth-mariadb
force-pushed
the
13.2-MDEV-40553-unprintable_gis-ranges-in-trace-and-context
branch
from
September 1, 2026 07:55
0598525 to
1575e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ranges were specified in a query for GIS types, the recorded trace
and context couldn't print the range information. Instead, it only
showed unprintable_geometry_value.
This PR extends the geometric field type Field_geom to print key value
in binary form (same as what is done for Blobs today), along with the
comparison operator, when recorded in the range.
For spatial indexes, the operators like MBRWITHIN, MBRCONTAINS, etc...
are stored appropriately, and for normal indexes, operators like
<, <=, >, >=, etc... are recorded appropriately.
Implementation Details: -
Add an argument imagetype to Field::print_key_part_value(), to determine
if an index key part value is to be printed in WKT or binary format.
For Geometric type, imagetype is set to itMBR. When printing ranges,
the MBR operators are printed as well, as implemented in
print_mbr_range_operator().