Skip to content

Commit 74ff4d3

Browse files
ggevayclaude
andcommitted
catalog: document the source and sink statuses the code produces
The column comments and the docs listed `failed` among the statuses of mz_source_statuses, mz_sink_statuses and their history relations, and omitted `paused` for sinks. The storage status enum has no `failed` variant and its parser rejects the string, no writer produces it, and the controller sets `paused` on sinks as well as sources when their cluster has no replica. `created` stays: the status views synthesize it for an object with no status recorded yet. The sink troubleshooting page named `failed` as well. The autogenerated catalog docs SLT is regenerated with ci/test/lint-docs-catalog.sh --rewrite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent fdd3007 commit 74ff4d3

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

doc/user/content/reference/system-catalog/mz_internal.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1280,7 +1280,7 @@ debugging.
12801280
| `name` | [`text`] | The name of the sink. |
12811281
| `type` | [`text`] | The type of the sink. |
12821282
| `last_status_change_at` | [`timestamp with time zone`] | Wall-clock timestamp of the sink status change. |
1283-
| `status` | [`text`] | The status of the sink: one of `created`, `starting`, `running`, `stalled`, `failed`, or `dropped`. |
1283+
| `status` | [`text`] | The status of the sink: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`. |
12841284
| `error` | [`text`] | If the sink is in an error state, the error message. |
12851285
| `details` | [`jsonb`] | Additional metadata provided by the sink. In case of error, may contain a `hint` field with helpful suggestions. |
12861286

@@ -1295,7 +1295,7 @@ messages and additional metadata helpful for debugging.
12951295
| -------------- | ------------------------------- | -------- |
12961296
| `occurred_at` | [`timestamp with time zone`] | Wall-clock timestamp of the sink status change. |
12971297
| `sink_id` | [`text`] | The ID of the sink. Corresponds to [`mz_catalog.mz_sinks.id`](../mz_catalog#mz_sinks). |
1298-
| `status` | [`text`] | The status of the sink: one of `created`, `starting`, `running`, `stalled`, `failed`, or `dropped`. |
1298+
| `status` | [`text`] | The status of the sink: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`. |
12991299
| `error` | [`text`] | If the sink is in an error state, the error message. |
13001300
| `details` | [`jsonb`] | Additional metadata provided by the sink. In case of error, may contain a `hint` field with helpful suggestions. |
13011301
| `replica_id` | [`text`] | The ID of the replica that an instance of a sink is running on. |
@@ -1402,7 +1402,7 @@ debugging.
14021402
| `name` | [`text`] | The name of the source. |
14031403
| `type` | [`text`] | The type of the source. |
14041404
| `last_status_change_at` | [`timestamp with time zone`] | Wall-clock timestamp of the source status change. |
1405-
| `status` | [`text`] | The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, `failed`, or `dropped`. |
1405+
| `status` | [`text`] | The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`. |
14061406
| `error` | [`text`] | If the source is in an error state, the error message. |
14071407
| `details` | [`jsonb`] | Additional metadata provided by the source. In case of error, may contain a `hint` field with helpful suggestions. |
14081408

@@ -1417,7 +1417,7 @@ messages and additional metadata helpful for debugging.
14171417
| -------------- | ------------------------------- | -------- |
14181418
| `occurred_at` | [`timestamp with time zone`] | Wall-clock timestamp of the source status change. |
14191419
| `source_id` | [`text`] | The ID of the source. Corresponds to [`mz_catalog.mz_sources.id`](../mz_catalog#mz_sources). |
1420-
| `status` | [`text`] | The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, `failed`, or `dropped`. |
1420+
| `status` | [`text`] | The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`. |
14211421
| `error` | [`text`] | If the source is in an error state, the error message. |
14221422
| `details` | [`jsonb`] | Additional metadata provided by the source. In case of error, may contain a `hint` field with helpful suggestions. |
14231423
| `replica_id` | [`text`] | The ID of the replica that an instance of a source is running on. |

doc/user/content/serve-results/sink/sink-troubleshooting.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ SELECT * FROM mz_internal.mz_sink_statuses
2121
WHERE name = <SINK_NAME>;
2222
```
2323

24-
If your sink reports a status of `stalled` or `failed`, you likely have a
25-
configuration issue. The returned `error` field will provide details.
24+
If your sink reports a status of `stalled`, you likely have a configuration
25+
issue. The returned `error` field will provide details.
2626

2727
If your sink reports a status of `starting` for more than a few minutes,
2828
[contact support](/support).

src/catalog/src/builtin/mz_internal.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,7 @@ pub static MZ_SOURCE_STATUS_HISTORY: LazyLock<BuiltinSource> = LazyLock::new(||
13181318
),
13191319
(
13201320
"status",
1321-
"The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, `failed`, or `dropped`.",
1321+
"The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`.",
13221322
),
13231323
(
13241324
"error",
@@ -2169,7 +2169,7 @@ pub static MZ_SOURCE_STATUSES: LazyLock<BuiltinView> = LazyLock::new(|| BuiltinV
21692169
),
21702170
(
21712171
"status",
2172-
"The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, `failed`, or `dropped`.",
2172+
"The status of the source: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`.",
21732173
),
21742174
(
21752175
"error",
@@ -2368,7 +2368,7 @@ pub static MZ_SINK_STATUS_HISTORY: LazyLock<BuiltinSource> = LazyLock::new(|| Bu
23682368
),
23692369
(
23702370
"status",
2371-
"The status of the sink: one of `created`, `starting`, `running`, `stalled`, `failed`, or `dropped`.",
2371+
"The status of the sink: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`.",
23722372
),
23732373
(
23742374
"error",
@@ -2451,7 +2451,7 @@ pub static MZ_SINK_STATUSES: LazyLock<BuiltinView> = LazyLock::new(|| BuiltinVie
24512451
),
24522452
(
24532453
"status",
2454-
"The status of the sink: one of `created`, `starting`, `running`, `stalled`, `failed`, or `dropped`.",
2454+
"The status of the sink: one of `created`, `starting`, `running`, `paused`, `stalled`, or `dropped`.",
24552455
),
24562456
(
24572457
"error",

test/sqllogictest/autogenerated/mz_internal.slt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ id text The␠ID␠of␠the␠sink.␠Corresponds␠to␠`mz_catalog.mz_sinks.
683683
name text The␠name␠of␠the␠sink.
684684
type text The␠type␠of␠the␠sink.
685685
last_status_change_at timestamp␠with␠time␠zone Wall-clock␠timestamp␠of␠the␠sink␠status␠change.
686-
status text The␠status␠of␠the␠sink:␠one␠of␠`created`,␠`starting`,␠`running`,␠`stalled`,␠`failed`,␠or␠`dropped`.
686+
status text The␠status␠of␠the␠sink:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠or␠`dropped`.
687687
error text If␠the␠sink␠is␠in␠an␠error␠state,␠the␠error␠message.
688688
details jsonb Additional␠metadata␠provided␠by␠the␠sink.␠In␠case␠of␠error,␠may␠contain␠a␠`hint`␠field␠with␠helpful␠suggestions.
689689

@@ -692,7 +692,7 @@ SELECT name, type, comment FROM objects WHERE schema = 'mz_internal' AND object
692692
----
693693
occurred_at timestamp␠with␠time␠zone Wall-clock␠timestamp␠of␠the␠sink␠status␠change.
694694
sink_id text The␠ID␠of␠the␠sink.␠Corresponds␠to␠`mz_catalog.mz_sinks.id`.
695-
status text The␠status␠of␠the␠sink:␠one␠of␠`created`,␠`starting`,␠`running`,␠`stalled`,␠`failed`,␠or␠`dropped`.
695+
status text The␠status␠of␠the␠sink:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠or␠`dropped`.
696696
error text If␠the␠sink␠is␠in␠an␠error␠state,␠the␠error␠message.
697697
details jsonb Additional␠metadata␠provided␠by␠the␠sink.␠In␠case␠of␠error,␠may␠contain␠a␠`hint`␠field␠with␠helpful␠suggestions.
698698
replica_id text The␠ID␠of␠the␠replica␠that␠an␠instance␠of␠a␠sink␠is␠running␠on.
@@ -722,7 +722,7 @@ id text The␠ID␠of␠the␠source.␠Corresponds␠to␠`mz_catalog.mz_sour
722722
name text The␠name␠of␠the␠source.
723723
type text The␠type␠of␠the␠source.
724724
last_status_change_at timestamp␠with␠time␠zone Wall-clock␠timestamp␠of␠the␠source␠status␠change.
725-
status text The␠status␠of␠the␠source:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠`failed`,␠or␠`dropped`.
725+
status text The␠status␠of␠the␠source:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠or␠`dropped`.
726726
error text If␠the␠source␠is␠in␠an␠error␠state,␠the␠error␠message.
727727
details jsonb Additional␠metadata␠provided␠by␠the␠source.␠In␠case␠of␠error,␠may␠contain␠a␠`hint`␠field␠with␠helpful␠suggestions.
728728

@@ -731,7 +731,7 @@ SELECT name, type, comment FROM objects WHERE schema = 'mz_internal' AND object
731731
----
732732
occurred_at timestamp␠with␠time␠zone Wall-clock␠timestamp␠of␠the␠source␠status␠change.
733733
source_id text The␠ID␠of␠the␠source.␠Corresponds␠to␠`mz_catalog.mz_sources.id`.
734-
status text The␠status␠of␠the␠source:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠`failed`,␠or␠`dropped`.
734+
status text The␠status␠of␠the␠source:␠one␠of␠`created`,␠`starting`,␠`running`,␠`paused`,␠`stalled`,␠or␠`dropped`.
735735
error text If␠the␠source␠is␠in␠an␠error␠state,␠the␠error␠message.
736736
details jsonb Additional␠metadata␠provided␠by␠the␠source.␠In␠case␠of␠error,␠may␠contain␠a␠`hint`␠field␠with␠helpful␠suggestions.
737737
replica_id text The␠ID␠of␠the␠replica␠that␠an␠instance␠of␠a␠source␠is␠running␠on.

0 commit comments

Comments
 (0)