Skip to content

ci: Nightly fixes (2026-08-31) - #38583

Open
bosconi wants to merge 1 commit into
mainfrom
jc/nightly-fixes-2026-08-31
Open

ci: Nightly fixes (2026-08-31)#38583
bosconi wants to merge 1 commit into
mainfrom
jc/nightly-fixes-2026-08-31

Conversation

@bosconi

@bosconi bosconi commented Aug 31, 2026

Copy link
Copy Markdown
Member

Based on https://buildkite.com/materialize/nightly/builds/18177 and https://buildkite.com/materialize/nightly/builds/18176

Motivation

bin/unused-deps has failed on every nightly since #18169, plus both v26.40.0 RC nightlies (#18172, #18174), on a single finding:

Found 1 unused dependencies:

  src/clusterd/Cargo.toml
      nix

Description

Remove nix from src/clusterd. #38250 moved the nix::sys::statvfs call out of src/clusterd/src/usage_metrics.rs and into src/metrics/src/usage.rs, which declares nix itself. That left the dependency stranded in the clusterd manifest: at the nightly commit there is no nix reference anywhere under src/clusterd/, so the rustc unused_crate_dependencies lint is correct and no [package.metadata.unused-deps] ignore entry is warranted.

Verification

bin/unused-deps locally, which is the failing check itself:

Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 28s
All dependencies are used.

plus cargo check -p mz-clusterd --lib --bins, clean. The Cargo.lock change is the corresponding one-line removal from the mz-clusterd dependency list.

Tips for reviewer

The check runs only in the nightly (ci/nightly/pipeline.template.yml), not in tests, which is why #38250 could merge with the stranded dependency. That looks like a deliberate cost decision given it is a full-workspace cargo check, so nothing here changes it.

Unlike most PRs in this series this one carries a single fix; the other failures in those two builds are not mechanical (a Terraform provider constraint, handled separately, an SLT flake, and a Workload Replay benchmark regression).

🤖 Generated with Claude Code

Based on https://buildkite.com/materialize/nightly/builds/18177 and
https://buildkite.com/materialize/nightly/builds/18176

Remove the `nix` dependency from `src/clusterd`. #38250 moved the
`nix::sys::statvfs` call out of `src/clusterd/src/usage_metrics.rs` and
into `src/metrics/src/usage.rs`, which declares `nix` itself, leaving the
dependency stranded in the clusterd manifest with no remaining use.

`bin/unused-deps` has failed on every nightly since #18169 for this one
finding; it now reports "All dependencies are used."

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@bosconi
bosconi requested a review from a team as a code owner August 31, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants