ci: Nightly fixes (2026-08-31) - #38583
Open
bosconi wants to merge 1 commit into
Open
Conversation
Based on https://buildkite.com/materialize/nightly/builds/18177 and https://buildkite.com/materialize/nightly/builds/18176 Remove the `nix` dependency from `src/clusterd`. #38250 moved the `nix::sys::statvfs` call out of `src/clusterd/src/usage_metrics.rs` and into `src/metrics/src/usage.rs`, which declares `nix` itself, leaving the dependency stranded in the clusterd manifest with no remaining use. `bin/unused-deps` has failed on every nightly since #18169 for this one finding; it now reports "All dependencies are used." Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
antiguru
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://buildkite.com/materialize/nightly/builds/18177 and https://buildkite.com/materialize/nightly/builds/18176
Motivation
bin/unused-depshas failed on every nightly since #18169, plus both v26.40.0 RC nightlies (#18172, #18174), on a single finding:Description
Remove
nixfromsrc/clusterd. #38250 moved thenix::sys::statvfscall out ofsrc/clusterd/src/usage_metrics.rsand intosrc/metrics/src/usage.rs, which declaresnixitself. That left the dependency stranded in the clusterd manifest: at the nightly commit there is nonixreference anywhere undersrc/clusterd/, so the rustcunused_crate_dependencieslint is correct and no[package.metadata.unused-deps] ignoreentry is warranted.Verification
bin/unused-depslocally, which is the failing check itself:plus
cargo check -p mz-clusterd --lib --bins, clean. TheCargo.lockchange is the corresponding one-line removal from themz-clusterddependency list.Tips for reviewer
The check runs only in the nightly (
ci/nightly/pipeline.template.yml), not intests, which is why #38250 could merge with the stranded dependency. That looks like a deliberate cost decision given it is a full-workspacecargo check, so nothing here changes it.Unlike most PRs in this series this one carries a single fix; the other failures in those two builds are not mechanical (a Terraform provider constraint, handled separately, an SLT flake, and a Workload Replay benchmark regression).
🤖 Generated with Claude Code