Skip to content

Bump VTK to 9.6 to fix Surface Nets problem - #14

Merged
MattTheCuber merged 3 commits into
masterfrom
update-vtk
Jun 4, 2026
Merged

Bump VTK to 9.6 to fix Surface Nets problem#14
MattTheCuber merged 3 commits into
masterfrom
update-vtk

Conversation

@MattTheCuber

@MattTheCuber MattTheCuber commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Closes #13

Notable Changes

  • Surface Nets inverted internal faces bug was fixed (see https://gitlab.kitware.com/vtk/vtk/-/issues/19156)
    • Removed the need to fill voids in testing and examples
  • Surface Nets mean mesh time dropped from to 9.28 seconds to 0.45 seconds
    • This raised the mean relative repair time from 3.35% to 87.83%
  • No impact on accuracy (maintained a 100% success rate)

@MattTheCuber MattTheCuber self-assigned this Apr 19, 2026
@MattTheCuber MattTheCuber added the bug Something isn't working label Apr 19, 2026
@github-actions

github-actions Bot commented Apr 19, 2026

Copy link
Copy Markdown

Coverage

Coverage for Python 3.13 on windows-latest
FileStmtsMissCoverMissing
edge_mender
   __init__.py20100% 
   data_factory.py1320100% 
   edge_mender.py1590100% 
   geometry_helper.py430100% 
   mesh_generator.py700100% 
   visualizer.py460100% 
TOTAL4520100% 

@MattTheCuber

Copy link
Copy Markdown
Owner Author

Currently testing on 10K random 10x10x10 datasets:

image

@MattTheCuber

Copy link
Copy Markdown
Owner Author

All passed btw:

image

@MattTheCuber

Copy link
Copy Markdown
Owner Author

Turns out this still fails with trimesh>4.9.0

@MattTheCuber

Copy link
Copy Markdown
Owner Author

@MattTheCuber
MattTheCuber merged commit 9a8d526 into master Jun 4, 2026
10 checks passed
@MattTheCuber
MattTheCuber deleted the update-vtk branch June 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not support holes

1 participant