Repository navigation
feat(history): j/k nav + bracket/star fixes - #232
Merged
Merged
Conversation
j and k now move the cursor down/up in the history OptionList when the filter is closed; when the filter is open, they're typed into the search like any other character.
Two bugs in the query history screen: 1. Bracket identifiers like [dbo].[ServiceFeatures] were truncated to "[dbo]." in the option list. rich.markup.escape only escapes brackets whose tag-name starts with [a-z#/@], so [ServiceFeatures] slipped through and Textual's markup parser ate it as an unknown tag. Build options (and the preview) as Rich Text instead of markup strings to sidestep parsing entirely. 2. Starring one row marked every same-text row as starred, because history dedup is per (connection, database, query_hash) but the starred store is keyed by (connection, query_text). Collapse rows with identical query text in _merge_entries (keeping the most-recent timestamp), so the display row count matches the starring model.
Maxteabag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds vim-style j/k navigation to the query history / telescope screen — moves the highlight down/up in the list when the filter is closed. When the filter is open, j and k are typed into the search like any other character, so fuzzy/substring matches that contain them still work.