Skip to content

Added has started, which adds way to check, whether CSSFX has been st… #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorianKirmaier wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added has started, which adds way to check, whether CSSFX has been st… #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45566a3
Added has started, which adds way to check, whether CSSFX has been st…
FlorianKirmaier Dec 12, 2022
5d14044
cssFXStartedProperty is now readonly
FlorianKirmaier Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions src/main/java/fr/brouillard/oss/cssfx/CSSFX.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
import java.util.Set;
import java.util.concurrent.Callable;

import javafx.beans.property.BooleanProperty;
import javafx.beans.property.ReadOnlyBooleanProperty;
import javafx.beans.property.SimpleBooleanProperty;
import javafx.collections.FXCollections;
import javafx.collections.ObservableList;
import javafx.scene.Node;
Expand All @@ -40,7 +43,29 @@

public class CSSFX {
// prevent multiple global starts of CSSFX
private static boolean isCssFXStarted = false;
private static boolean isGlobalCssFXStarted = false;

private static boolean isAnyCssFXStarted = false;


private static BooleanProperty cssFXStarted = new SimpleBooleanProperty(false);
Comment on lines +46 to +51

@McFoggy McFoggy Dec 19, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of keeping several states? isn't only one enough?

@FlorianKirmaier FlorianKirmaier Dec 19, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isGlobalCssFXStarted prevents starting CSSFX.start() twice - which would end in twice as many listeners.

isAnyCssFXStarted just tells us, whether CSSFX was started in any way.

It's worth noting, that It's not really possible to start CSSFX.



/**
* A property which indicates if CSSFX is started or not.
* @return the property
*/
public static ReadOnlyBooleanProperty cssFXStartedProperty() {
return cssFXStarted;
}

/**
* @return Indicates if CSSFX is started or not.
*/
public static boolean isCSSFXStarted() {
return cssFXStarted.get();
}


/**
* Directly start monitoring the CSS of the application using defaults:
Expand All @@ -51,8 +76,8 @@ public class CSSFX {
* @return a Runnable object to stop CSSFX monitoring
*/
synchronized public static Runnable start() {
if(!isCssFXStarted) {
isCssFXStarted = true;
if(!isGlobalCssFXStarted) {
isGlobalCssFXStarted = true;
return new CSSFXConfig().start();
} else {
return () -> {};
Expand Down Expand Up @@ -199,11 +224,14 @@ public CSSFXConfig addConverter(URIToPathConverter converter) {
* @return a Runnable object to stop CSSFX monitoring
*/
public Runnable start() {

if(Boolean.getBoolean("cssfx.disable")) {
System.out.println("CSSFX was not started, because it's disabled via the system property 'cssfx.disable'");
return () -> {};
}

cssFXStarted.set(true);

Comment on lines +233 to +234

@McFoggy McFoggy Dec 19, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we lack a cleanup of this state change during stop action

@FlorianKirmaier FlorianKirmaier Dec 19, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop mechanism doesn't really work.
The listener still stays active.
And it's not really used in any application I know of.
So I would rather suggest removing the stop method.

if (!CSSFXLogger.isInitialized()) {
if (Boolean.getBoolean("cssfx.log")) {
LogLevel toActivate = LogLevel.INFO;
Expand Down