You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0ca1dbd
Browse filesBrowse the repository at this point in the historyBrowse files
process: third review round on the merge-review rule (verbatim fixes)
CHANGELOG states the 2,000-word trim trigger; the fixture-asking sentence names
the reviewer exception; reviewers re-measure the word count; "unreviewed" inbox
files means content not vetted, and their PRs still get the merge review.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@ Sections dated before 2026-09-19 predate the cycle and stay as they are.
18
18
## Unreleased
19
19
20
20
- process(merging): **every PR gets an independent review before it merges — a merge go is not a review.** A reviewer that did not write the PR returns MERGE / MERGE-AFTER-FIX / HOLD on value, regression risk after sync, correctness and context cost; builder self-reports and green CI no longer count. Nine PRs merged on 2026-10-13 without one. — MendixMau
21
-
- process(context): **the baseline word budget is made room for by moving text, never by deleting rules.** Rules, STOP rows, denominators and failure examples are protected; stories and examples move behind pointers in a separate, independently reviewed trim PR; trim starts at 95% of the cap. — MendixMau
21
+
- process(context): **the baseline word budget is made room for by moving text, never by deleting rules.** Rules, STOP rows, denominators and failure examples are protected; stories and examples move behind pointers in a separate, independently reviewed trim PR; a trim PR lands first when a PR would take the baseline within 2,000 words of the cap. — MendixMau
22
22
- learn(testing-shape, test-result-audit): **three test-strength rules, each with a denominator: refusals probed on the server, every undeclared 4xx a failure, one clean-database final run** ([#172](https://github.com/MendixMau/mxcli-project-toolkit/issues/172)). A field comparison of two builds against one frozen spec found the toolkit build checked permission refusals only in the client (a hidden menu item), logged unexpected 400/422 responses as information, and reached 20/20 by stitching three runs. `testing-shape.md` §7 gains three report lines (`N of N restricted pairs probed server-side`, `undeclared 4xx/5xx: 0 of M requests — each fails its step`, `one clean-DB run <id>: N of N scenarios incl. timers, not stitched`); `test-result-audit.md` gains check 2e, which carries the reasons and the field evidence and asks for those numbers. Both baseline skills stay inside the 80,000-word baseline budget (79,997): the reasons live in the on-demand audit skill, and two redundant sentences in `testing-shape.md` §4's verdict paragraphs were folded (the empty-set corollary is stated in the Trace row, `harness-architecture.md` and `report-schema.md`). The backing inbox note is trimmed to its unpromoted "Keep" items. — MendixMau
23
23
- learn(learned-detection-gaps, module-review): **two UI defects every model gate passes: a lazy-loaded combo box filter hides its preset, and a theme that pins row heights by position lets the next row cover an inserted widget** ([#299](https://github.com/MendixMau/mxcli-project-toolkit/issues/299)). Both passed check, mxbuild, lint and the scripted checks on a 127-module production app and were found only in the running app. Two register rows with the first oracle and the pre-build check (pluggable properties that change *when* data loads; grep the theme for fixed `height` on positional row classes before an insert), and two LOOK lines in `module-review.md` §4c with denominators (`N of N filters show their preset on first load`, `N of N widgets inserted into an existing container fully visible`). — jopterhorst
24
24
- fix(app-restart, test-stack-up): **a port held by another process before `run --local` is named and reported as "instrument blocked" (exit 4), never killed** ([#262](https://github.com/MendixMau/mxcli-project-toolkit/issues/262)). Studio Pro had started its own runtime on the app/admin ports a restart needed; `mxcli run --local` then failed with "Authentication failed" (the admin API answering was Studio Pro's), the next journey ran against Studio Pro's runtime, and four more runs were NOT RUN. `app-restart.sh` now checks the app port and the admin port (record's `adminPort`, else app + 10) before stopping anything — a holder outside the recorded process tree exits 4 with its name, pid and parent — and again after the stop, where anything still holding a port is by definition not ours. `test-stack-up.sh` runs the same check wherever it would tell you to start `run --local` (`--no-docker`, no Docker daemon, `--check` with a leftover record), on the record's ports, `RUN_LOCAL_APP_PORT`/`RUN_LOCAL_ADMIN_PORT`, or mxcli's defaults 8080/8090. Holder lookup: lsof, then ss, then netstat + tasklist on Windows; unnamed holders still block when nothing of ours is running. Fixtures: `test-app-restart.sh` +2 cases (14 assertions, all fail on the old script), `test-stack-up-local.sh` T7 (4 of 6 fail on the old script). — AlvinnYeo
Copy file name to clipboardExpand all lines: CLAUDE.md
+4-3Lines changed: 4 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -177,7 +177,8 @@ never count: the builder grades its own work, and CI proves only the tests the b
177
177
`sync-project.sh` (new FAIL / BLIND / refusals, exit codes, output another tool parses, gate
178
178
verdicts that flip), across both layouts and macOS / Git Bash? *Correctness*: real bugs, tests
179
179
that do not test what they claim, hand-written golden input where a capture was required.
180
-
*Context cost*: words added to always-loaded skill files.
180
+
*Context cost*: words added to always-loaded skill files — re-measured by the reviewer, not taken
181
+
from the PR body.
181
182
3.**Verdict.**`MERGE`, `MERGE-AFTER-FIX` (exact fixes listed; the fixes are pushed and
182
183
re-reviewed before merge) or `HOLD` (goes back to the maintainer with the reason). Only `MERGE`
183
184
merges.
@@ -237,7 +238,7 @@ and tag every few days — the release cycle is defined at the top of `CHANGELOG
237
238
238
239
Contributions arrive through three lanes (`CONTRIBUTING.md`): the `contrib/inbox/` drop
239
240
(no quality bar — triage promotes into `skills/`/`bug-logs/`/`bin/` and deletes the inbox file
240
-
in the same commit; inbox files are unreviewed and nothing may cite them),
241
+
in the same commit; inbox files are unreviewed — their content is not vetted for promotion — and nothing may cite them; a PR that adds one still gets the merge review below),
241
242
`bin/harvest-learnings.sh <project-root>` (drafts inbox files from a project's bug logs,
242
243
register promotion tables, and locally-patched installed scripts — run it at project wrap-up),
243
244
and direct PRs held to the full field-proof bar. CI (`.github/workflows/checks.yml`) runs
@@ -347,7 +348,7 @@ fixtures the PR adds or that target its changed files, without asking, in a deta
347
348
the PR branch. That isolation is what avoids the shared-tree problem above; the reviewer still
348
349
never runs the full suites.
349
350
350
-
**Asking is also required for a single fixture** — name it, say what it will tell us, and wait.
351
+
**Outside that reviewer exception, asking is also required for a single fixture** — name it, say what it will tell us, and wait.
351
352
352
353
Where a fixture's assertions are greps over a file you changed, prefer verifying by inspection:
353
354
read the fixture, replicate its greps against the changed file, and report that. Same signal, no
0 commit comments