Repository navigation
Commit 6615869
fix(lint): rename the toolkit's CONV020 rule to MXTK-UX003 — mxcli v0.28 ships a built-in CONV020 (#573)
mxcli v0.28.0 adds a built-in CONV020 (mendixlabs/mxcli#1518) and has no duplicate-ID guard, so it and the toolkit's page-action user-feedback rule ran under one ID (one config key, one -r selector, one lint-gate count). Captured on the public pedapp model, v0.27 vs v0.28.
The toolkit rule is now MXTK-UX003 (lint-rules/mxtk_ux003_action_user_feedback.star); the MXTK- prefix is one mxcli does not use. sync/init migrate each project: an unedited copy (md5 of any shipped version) is replaced and its receipt moved; an edited copy is left byte-identical with manual steps and the new rule held back; lint-baseline.json findings move to MXTK-UX003 only when the message is the toolkit rule's (built-in CONV020 stays); counts-only baselines get a one-time NOTE. A lint-config CONV020 opt-out is carried over to lint-rules-disabled.txt, reading exactly mxcli v0.28's yaml.v3 false set (false/False/FALSE, n/N/no/No/NO, off/Off/OFF), any key quoting, direct child or flow map, LF or CRLF, from mxcli's FindConfigFile order. lint-gate --update-baseline records mxcli_version; doctor prints a re-baseline hint when it differs (note only, no extra mxcli call). test-lint-rule-rename 141/141 on both layouts with golden v0.28 captures. Field-proof gap: no real project with the old rule installed has been migrated yet; steps are in the PR. Known edge cases left documented: YAML anchors/tags, CONV020 under a non-rules parent, and the two-tree config location (mxcli reads the config beside the .mpr; toolkit-wide follow-up).
Review: MERGE — four review rounds: opt-out carry-over (round 1), mxcli false set/quoting/nesting (round 2), CRLF config (round 3), fix verified (round 4); known YAML edge cases and the two-tree config location left documented
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr1 parent b082f4b commit 6615869
30 files changed
Lines changed: 1085 additions & 49 deletions
File tree
- bin
- lib
- bug-logs
- lint-rules
- project-bin
- skills
- tests
- wave2
- fixtures/lint-conv020-v028
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1546 | 1546 | | |
1547 | 1547 | | |
1548 | 1548 | | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
1549 | 1575 | | |
1550 | 1576 | | |
1551 | 1577 | | |
| |||
1558 | 1584 | | |
1559 | 1585 | | |
1560 | 1586 | | |
1561 | | - | |
1562 | 1587 | | |
1563 | 1588 | | |
1564 | 1589 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
| 439 | + | |
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
| |||
0 commit comments