Repository navigation
Commit b3d6b66
committed
fix(alter page): address tab pages by the name DESCRIBE prints
`alter page M.P { drop widget tabPage2 }`, `set Visible ... on tabPage2`
and `set Class ... on tabPage2` all failed with `widget "tabPage2" not
found. DataGrid2 columns are addressed by a derived name ...`, although
DESCRIBE PAGE prints `tabpage tabPage2` and widgets inside the tab page
resolved fine.
The page mutator's finder, widget-scope collector and enclosing-datasource
finder walked TabPages[].Widgets but never compared the tab page's own
Name. They now search TabPages as a widget array, which matches the tab
page and still descends into its children.
With tab pages addressable, their invariants are enforced:
- dropping the last tab page is refused (drop the tab container instead);
- dropping or replacing the default tab page repoints DefaultPagePointer,
which would otherwise dangle;
- only tab pages may sit beside a tab page, and a tab page only in a tab
container; INSERT INTO a tab container appends tab pages, INSERT INTO a
tab page appends ordinary widgets;
- set Class/Style/DynamicClasses on a tab page is refused (it has no
Appearance; the setter reported success and wrote nothing);
- set Caption on a Texts$Text caption now updates its Items translations
instead of writing a stray Text key onto the Texts$Text.
A top-level `tabpage` body in ALTER PAGE is now built and serialized
(tabPageToGen, extracted from the TabContainer case).
The not-found error now leads with `widget "X" not found` and keeps the
DataGrid2 column addressing as a secondary hint.
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 57259e8 commit b3d6b66
8 files changed
Lines changed: 615 additions & 52 deletions
File tree
- .claude/skills
- fix-issue/findings
- mendix/alter-page
- mdl-examples/bug-tests
- mdl
- backend
- modelsdk
- pagemutator
- executor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
260 | | - | |
261 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
262 | 271 | | |
263 | 272 | | |
264 | 273 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
288 | 313 | | |
289 | 314 | | |
290 | 315 | | |
291 | 316 | | |
292 | 317 | | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
293 | 323 | | |
294 | 324 | | |
295 | 325 | | |
| |||
316 | 346 | | |
317 | 347 | | |
318 | 348 | | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
338 | 352 | | |
339 | 353 | | |
340 | 354 | | |
| |||
0 commit comments