fix: clone fields array in buildClassMetadata to prevent FieldResolver metadata leak into dual-type InputType - #1811
Open
MichalLytek with Copilot wants to merge 3 commits into
Open
fix: clone fields array in buildClassMetadata to prevent FieldResolver metadata leak into dual-type InputType#1811MichalLytek with Copilot wants to merge 3 commits into
MichalLytek with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix FieldResolver metadata leak into InputType for dual-type classes
fix: clone fields array in buildClassMetadata to prevent FieldResolver metadata leak into dual-type InputType
May 11, 2026
MichalLytek
approved these changes
May 11, 2026
There was a problem hiding this comment.
Pull request overview
Fixes a metadata-mutation bug in MetadataStorage that affects “dual-type” classes (decorated with both @ObjectType() and @InputType()), where later @FieldResolver processing could accidentally mutate a shared fields array and leak resolver fields into the InputType, leading to CannotDetermineGraphQLTypeError during schema build.
Changes:
- Clone the cached
fieldsarray when assigning it to each class metadata definition to avoid cross-definition mutation. - Add a functional regression test that reproduces the dual-type + external
@FieldResolverscenario and asserts schema building succeeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/metadata/metadata-storage.ts |
Prevents fields array reference sharing across object/input definitions by cloning on assignment. |
tests/functional/resolvers.ts |
Adds a regression test ensuring external field resolvers don’t leak into @InputType() fields for dual-decorated classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot add new entry to the changelog.md, in the unreleased section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MutationusingDualClassInputas argument so the InputType is reachable in the schemaDualClassObjectType contains thecomputedfield resolverDualClassInputInputType does NOT contain thecomputedfield resolver