Repository navigation
fix: cache App Link host SSRF verdicts and log them once - #2723
Merged
ajinabraham merged 3 commits intoOct 24, 2026
Merged
Conversation
Manifest analysis calls valid_host() (a DNS lookup) for every <data android:host=...> declaration across all browsable intent filters. Apps with many activities that deep-link to the same (non-public) hosts perform hundreds of identical DNS queries and emit hundreds of duplicate 'Invalid Host' warnings per scan. Cache the verdict per host: behavior is unchanged, each host is resolved and logged exactly once per manifest parse.
|
Thank you for sending this pull request ❤️. Please make sure you have followed our contribution guidelines. We will review it as soon as possible |
ajinabraham
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)
🤖 Generated with O3 Agent Claude
