🐛 Fix incomplete model config handling - #3816
Open
original4422 wants to merge 1 commit into
Open
Conversation
original4422
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
August 30, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_repoormodel_namerepo/nameformattingRoot cause
TenantConfigManager.get_model_configcan return an empty default mapping for invalid model IDs, butget_model_name_from_configindexed both keys directly. That mismatch raisedKeyErrorbefore callers could handle the empty model name.Testing
python -m pytest test/backend/utils/test_config_utils.py -q(35 passed)python -m compileall -q backend/utils/config_utils.py test/backend/utils/test_config_utils.pyuvx ruff check --select E9,F63,F7,F82 backend/utils/config_utils.py test/backend/utils/test_config_utils.pygit diff --checkFixes #3810