🐛 Make GlobalThreadPool initialization thread-safe - #3824
Open
original4422 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitdelegationRoot cause
GlobalThreadPool.__new__published_instancebeforeThreadPoolExecutorconstruction completed, so another thread could receive an incompletely initialized singleton. It also silently retained the first worker count on later conflicting calls.Testing
uv run --with pytest pytest test/backend/utils/test_thread_utils.py -q(3 passed)uv run --with ruff ruff check backend/utils/thread_utils.py test/backend/utils/test_thread_utils.pygit diff --checkFixes #3820