[Bugfix] Improve auto trace parsing diagnostics - #1218
Draft
dante159753 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--log-dirto accept either a directory or a single log file, regardless of the file extension.parse_failure_countandparse_failuresin the generated analysis result.--trace-outputis enabled.Why
Long
ucm_block_idslog messages can be truncated before the list terminator. The existing non-greedy list pattern may then consume a later logger metadata bracket, andast.literal_evalfails without identifying the offending line or parsing stage. One malformed line also previously aborted the entire analysis.The new diagnostics make the source of malformed records actionable while allowing valid records later in the same file or other scanned files to remain usable.
Impact
Users can analyze a pasted or individually selected log file directly, see the exact input set, and still receive cache-hit analysis when only part of the trace is malformed. Completely unusable inputs continue to fail the existing aggregate validation.
Verification
The commit-time codespell, Black, isort, and GitHub Actions workflow lint hooks also pass.