Skip to content

[Bugfix] Adjust log rate limiting defaults - #1239

Open
dante159753 wants to merge 1 commit into
ModelEngine-Group:developfrom
dante159753:bugfix-log-rate-limit-window
Open

[Bugfix] Adjust log rate limiting defaults#1239
dante159753 wants to merge 1 commit into
ModelEngine-Group:developfrom
dante159753:bugfix-log-rate-limit-window

Conversation

@dante159753

Copy link
Copy Markdown
Contributor

What changed

  • Increase the default UCM log rate-limit window from 10 seconds to 60 seconds while keeping the three-log limit unchanged.
  • Make store health breaker state-transition warnings bypass rate limiting.
  • Update logger documentation and regression coverage for both behaviors.

Why

A longer default window reduces repeated log noise. Health breaker transitions are operationally significant state changes, so they must remain visible even when multiple transitions occur within one rate-limit window.

Impact

Rate-limited logs now allow at most three entries per call site in a 60-second window by default. UCM_LOG_RATE_LIMIT_WINDOW_MS can still override the default. Store health breaker transition warnings are always emitted.

Verification

  • Commit hooks: codespell, black, and isort passed.
  • Direct invocation of all five checks in test/test_logger.py passed.
  • python -m pytest test/test_logger.py -q was also attempted, but the Windows test environment stopped in the repository-wide fixture because the Unix-only fcntl module is unavailable.

@dante159753
dante159753 marked this pull request as ready for review August 18, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant