[Bugfix] Reinitialize logger backends after fork - #1313
Open
dante159753 wants to merge 1 commit into
Open
Conversation
dante159753
requested review from
FangRun2,
Tarrei,
Wwwzff,
mag1c-h and
ygwpz
as code owners
August 31, 2026 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
vLLM initializes UCM logging before spawning the V1 EngineCore. With the
forkmultiprocessing method, the vLLM EngineCore process inherits spdlog objects, mutexes, and async queue state, but it does not inherit the logger worker threads. EngineCore and tensor-parallel workers can therefore execute normally while their UCM-managed file logs are never drained.The child now detects the PID mismatch on its first logger operation and initializes its own backend. The parent does not need to stop or reinitialize its logger.
What changed
fork().*_oncelogger caches throughos.register_at_fork()so child logging is not suppressed by parent cache entries.ucm-<pid>.logandvllm-<pid>.logfiles.