MuPDF version change requires minor change in mupdf_renderer.cpp

[kovzol]

On Ubuntu 26.04 there is a new version of MuPDF (1.27) which requires a signature change for pdf_new_run_processor. This patch handles this issue:

diff --git a/src/Plugins/MuPDF/mupdf_renderer.cpp b/src/Plugins/MuPDF/mupdf_renderer.cpp
index dfea84ec3..6b3bd6ee1 100644
--- a/src/Plugins/MuPDF/mupdf_renderer.cpp
+++ b/src/Plugins/MuPDF/mupdf_renderer.cpp
@@ -215,8 +215,15 @@ mupdf_renderer_rep::begin (void* handle) {
     h            = fz_pixmap_height (ctx, pixmap);
     dev          = fz_new_draw_device (ctx, fz_identity, pixmap);
     fz_matrix ctm= fz_make_matrix (1, 0, 0, -1, 0, 0);
+
+#include <mupdf/fitz/version.h>
+#if FZ_VERSION_MAJOR > 1 || (FZ_VERSION_MAJOR == 1 && FZ_VERSION_MINOR >= 27)
+    proc= pdf_new_run_processor (ctx, mupdf_document (), dev, ctm, -1, "View",
+                                 NULL, NULL, NULL, NULL, NULL);
+#else
     proc= pdf_new_run_processor (ctx, mupdf_document (), dev, ctm, -1, "View",
                                  NULL, NULL, NULL);
+#endif
 
     fg              = -1;
     bg              = -1;

[JimZhouZZY]

Thanks for the report and fix.

Mogan currently uses a fixed version of MuPDF. Are you compiling it with any custom build options?

xmake/packages/m/mupdf/xmake.lua

    add_versions("1.24.10", "939285b5f97caf770fd46cbe7e6cc3a695ab19bb5bfaf5712904549cef390b7b")
    add_versions("1.25.1", "81aa1361252418cc45347b4ac075532096957a7ab772e20e046f3bb418d7263c")

[kovzol]

I have another MuPDF installation that comes from Ubuntu 26.04 (libmupdf-dev).
I had a similar problem with the packages qt6-base-dev, qt6-base-dev-tools and qmake6 which had to be removed before I managed to build Mogan. The documentation explicitly writes this requirement in devel/Develop_on_Linux.md, but it does not mention that other packages should also be removed.
In fact, the best way would be to instruct xmake to ignore the system versions of these packages. Otherwise the build process mixes the system libraries with the fixed versions given in xmake's configuration and this is either not working (as in the case of Qt 6.10.2 on my system) or may lead to some other issues.
As a workaround, it would be be possible to create, say, a Dockerfile that starts the build from a clean Ubuntu (or Debian) system and there would not be such interferences between system-wide installation and Mogan's own settings.

[JimZhouZZY]

Yea, I found that requires.lua currently mixes the system MuPDF package on some Linux systems. I'm not sure why tho.

@da-liii Any idea?

[da-liii]

just do not depend on the apt provided mupdf

[da-liii]

I prefer move the source code of mupdf to 3rdparty