Fix OOV report tokenization and logged paths - #955
Open
p3zo wants to merge 2 commits into
Open
Conversation
p3zo
force-pushed
the
fix/utterance-oovs-tokenization
branch
2 times, most recently
from
May 2, 2026 04:00
5462a0c to
85db3b9
Compare
p3zo
force-pushed
the
fix/utterance-oovs-tokenization
branch
from
May 2, 2026 04:01
85db3b9 to
70db128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes related to OOV reporting:
Utterance.oovsis a space-delimited string but treated as an iterable, causingutterance_oovs.txtand OOV token counts to be character-based. Resolved by splitting the strings into word tokens before writingutterance_oovs.txt. This fixes [BUG] OOV count reflects number of characters not tokens #926.The logs print
oovs_found.txt, while the files that are actually written are dictionary-specific files likeoovs_found_english_mfa.txt. Resolved by logging the dictionary-specific OOV report paths.