Skip to content

[pull] main from DeusData:main - #128

Merged
pull[bot] merged 7 commits into
MrDolphin:mainfrom
DeusData:main
Sep 3, 2026
Merged

pull[bot] merged 7 commits into
MrDolphin:mainfrom
DeusData:main

Conversation

@pull

@pull pull Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

angusgastle and others added 7 commits September 1, 2026 10:24
Signed-off-by: Angus Gastle <angusgastle@gmail.com>
Address maintainer review on PR #1697:
- LFS pattern goes in the repo-root .gitattributes; the auto-created
  .codebase-memory/.gitattributes (bare graph.db.zst, merge=ours) is
  kept as-is, since a slash-containing pattern inside it would anchor
  to .codebase-memory/ and match nothing
- Lead with commit cadence as the cheaper fix; LFS is for teams that
  need the artifact to move on every commit
- Name the LFS costs: metered storage/bandwidth, no pruning without
  support, and teammates without `git lfs install` fall back to a
  full reindex

Co-Authored-By: Claude Code <noreply@anthropic.com>
Signed-off-by: Angus Gastle <angusgastle@gmail.com>
`g_mcp_command_path_probe_counter` is only ever read inside
`cbm_json_mcp_probe_command_path`, which is compiled for Windows alone.
On POSIX test builds the setter stored a pointer nothing read, and Clang
23 (Homebrew LLVM 23.1.0, which `brew install llvm` now pours on the
macOS LSan leg) flags that as `-Wunused-but-set-global`; with `-Werror`
the whole test-runner build dies at `src/cli/cli.c:1768:21`.

Keep the counter where a probe can happen (Windows) and make the POSIX
setter an explicit no-op with the reason spelled out. The three tests
that install a counter keep asserting it stays at zero on every platform,
which on POSIX is exactly what "no classifier" means.

Verified in the failing arena: `origin/main` `src/cli/cli.c` fails under
clang 23.1.1 with the CI diagnostic; with this change it compiles clean,
as do all 105 built `src` TUs and all 155 test + extraction TUs under the
same flags. `cli` suite: 292 passed with Homebrew LLVM 22.

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
…-but-set

fix(cli): drop the POSIX probe-counter store that Clang 23 rejects
…ance

docs: recommend Git LFS for team-shared graph artifact
@pull pull Bot locked and limited conversation to collaborators Sep 3, 2026
@pull pull Bot added the ⤵️ pull label Sep 3, 2026
@pull
pull Bot merged commit 2f9828d into MrDolphin:main Sep 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants