⚡ Bolt: [performance improvement] - #192
Conversation
…me Map allocations Co-authored-by: servathadi <116760885+servathadi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 What
Moved the
nodeMapinitialization out of therequestAnimationFramerender loop (simulate()) inKnowledgeGraph.tsxand cached it in auseRef.🎯 Why
Instantiating
new Map()and iterating to populate it inside a hot loop (running at 60 FPS) causes unnecessary per-frame memory allocation. This triggers frequent garbage collection (GC) pauses, which can lead to visible frame drops and canvas jank.📊 Impact
Eliminates O(N) memory allocations and dictionary writes per frame. Results in smoother rendering and significantly reduced garbage collection pressure.
🔬 Measurement
Measure performance in Chrome DevTools Performance tab: the "Scripting" time and Garbage Collection events should be significantly lower during the visualization simulation.
PR created automatically by Jules for task 16239130230368200542 started by @servathadi