Address model manager review feedback

Author: Copilot

CMakeLists.txt

@@ -123,7 +123,9 @@ add_subdirectory(asr)
 add_subdirectory(translate)
 add_subdirectory(tts)
 add_subdirectory(pipeline)
-add_subdirectory(apps)
+if(VOX_BUILD_APPS OR VOX_BUILD_TESTS)
+    add_subdirectory(apps)
+endif()
 
 if(VOX_BUILD_TESTS)
     enable_testing()

apps/model_manager.cpp

@@ -72,7 +72,15 @@ int run_download_command(const ManagedModel & model, const std::filesystem::path
         return 1;
     }
     const int result = std::system(model.download_command.c_str());
-    std::filesystem::current_path(previous, ec);
+    std::error_code restore_ec;
+    std::filesystem::current_path(previous, restore_ec);
+    if (restore_ec) {
+        err << "Could not restore working directory " << previous << ": " << restore_ec.message() << "\n";
+        if (result != 0) {
+            err << "Download command failed for " << model.name << ".\n";
+        }
+        return 1;
+    }
     if (result != 0) {
         err << "Download command failed for " << model.name << ".\n";
         return 1;
@@ -238,7 +246,7 @@ int run_model_command(
         installed_only = args.size() == 2;
         for (const ManagedModel & model : supported_models()) {
             const ManagedModelStatus status = inspect_model(model, project_root);
-            if (installed_only && !status.complete) {
+            if (installed_only && !status.installed && !status.has_partial_download) {
                 continue;
             }
             out << model.name << "\t" << status_name(status) << "\t" << model.version << "\t";

apps/model_manager.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <filesystem>
 #include <iosfwd>
 #include <string>

tests/model_manager_test.cpp

@@ -1,9 +1,11 @@
 #include "model_manager.h"
 
+#include <chrono>
 #include <filesystem>
 #include <fstream>
 #include <iostream>
 #include <sstream>
+#include <string>
 
 namespace {
 
@@ -21,7 +23,8 @@ int main() {
     namespace fs = std::filesystem;
 
     bool ok = true;
-    const fs::path root = fs::temp_directory_path() / "vox_model_manager_test";
+    const auto now = std::chrono::steady_clock::now().time_since_epoch().count();
+    const fs::path root = fs::temp_directory_path() / ("vox_model_manager_test_" + std::to_string(now));
     std::error_code ec;
     fs::remove_all(root, ec);
     fs::create_directories(root / "models", ec);
@@ -43,16 +46,24 @@ int main() {
     status = vox::app::model::inspect_model(*model, root);
     ok = expect(status.installed && !status.complete, "empty model file should be incomplete") && ok;
 
+    std::ostringstream out;
+    std::ostringstream err;
+    int result = vox::app::model::run_model_command({"list", "--installed"}, root, out, err);
+    ok = expect(result == 0, "list --installed should succeed for incomplete models") && ok;
+    ok = expect(out.str().find("whisper-base") != std::string::npos, "installed list should include incomplete model") && ok;
+
     {
         std::ofstream file(model_path, std::ios::binary);
         file << "not a real model, but enough to test file completeness";
     }
     status = vox::app::model::inspect_model(*model, root);
     ok = expect(status.installed && status.complete, "non-empty model file should be complete") && ok;
 
-    std::ostringstream out;
-    std::ostringstream err;
-    int result = vox::app::model::run_model_command({"verify", "whisper-base"}, root, out, err);
+    out.str("");
+    out.clear();
+    err.str("");
+    err.clear();
+    result = vox::app::model::run_model_command({"verify", "whisper-base"}, root, out, err);
     ok = expect(result == 0, "verify should succeed for a complete local model") && ok;
     ok = expect(out.str().find("checksum: unavailable") != std::string::npos, "verify should show checksum status") && ok;
 
@@ -72,6 +83,20 @@ int main() {
     ok = expect(result == 0, "remove should succeed") && ok;
     ok = expect(!fs::exists(model_path), "remove should delete model file") && ok;
 
+    {
+        std::ofstream partial(model_path.string() + ".part", std::ios::binary);
+        partial << "partial";
+    }
+    status = vox::app::model::inspect_model(*model, root);
+    ok = expect(!status.installed && status.has_partial_download && !status.complete, "partial download should be incomplete") && ok;
+    out.str("");
+    out.clear();
+    err.str("");
+    err.clear();
+    result = vox::app::model::run_model_command({"list", "--installed"}, root, out, err);
+    ok = expect(result == 0, "list --installed should succeed for partial downloads") && ok;
+    ok = expect(out.str().find("whisper-base") != std::string::npos, "installed list should include partial download") && ok;
+
     fs::remove_all(root, ec);
     return ok ? 0 : 1;
 }