output/Source.cxx: cross-fade using the ReplayGainFilter's output format - #2573
Merged
MaxKellermann merged 1 commit intoAug 22, 2026
Merged
MaxKellermann merged 1 commit into
MaxKellermann merged 1 commit into
Conversation
When software volume is enabled (mixer_type "software"), the ReplayGainFilter converts S16 input to S24_P32 (PcmVolume::Open() with allow_convert=true) to avoid losing precision. FilterChunk() applied that filter to both chunks and then called pcm_mix() with in_audio_format.format (S16) on data that was already S24_P32. Mixing 32-bit samples as if they were 16-bit produces loud noise for the whole cross-fade duration. OpenFilter() already uses the ReplayGainFilter's output format for the rest of the filter chain; use it for the cross-fade mix as well. Fixes MusicPlayerDaemon#2050, probably also MusicPlayerDaemon#1101.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With software volume enabled ReplayGainFilter converts S16 input to S24_P32 (PcmVolume::Open() with allow_convert=true). FilterChunk() applied that filter to both chunks and then called pcm_mix() with in_audio_format.format (S16) on data that was already S24_P32. Mixing 32-bit samples as if they were 16-bit produces noise in the cross-fade.
It seem to fix #2050, probably also #1101. I've been using it on my mpds for 3 months and have not heard any crossfade noise or noticed any other problems.