CCM-23428: fix sonarqube error in main (#747)

* fix sonarqube error in main

* update unit test coverage

* fix lint issues

Author: Vlasis-Perdikidis

lambdas/authorizer/src/__tests__/index.test.ts

@@ -139,6 +139,25 @@ describe("Authorizer Lambda Function", () => {
 
       expect(metricScope).not.toHaveBeenCalled();
     });
+
+    it("Should log an error when the certificate expiry check fails", async () => {
+      mockEvent.requestContext.identity.clientCert = buildCertWithExpiry(
+        "2025-11-31T14:19:00Z",
+      );
+      const error = new Error("Metrics failure");
+      (metricScope as jest.Mock).mockImplementationOnce(() =>
+        jest.fn().mockRejectedValue(error),
+      );
+
+      const handler = createAuthorizerHandler(mockedDeps);
+      handler(mockEvent, mockContext, mockCallback);
+      await new Promise(process.nextTick);
+
+      expect(mockedDeps.logger.error).toHaveBeenCalledWith({
+        description: "Error checking certificate expiry",
+        err: error,
+      });
+    });
   });
 
   describe("Supplier ID lookup", () => {

lambdas/authorizer/src/authorizer.ts

@@ -19,7 +19,15 @@ export default function createAuthorizerHandler(
     context: Context,
     callback: Callback<APIGatewayAuthorizerResult>,
   ): void => {
-    checkCertificateExpiry(event.requestContext.identity.clientCert, deps);
+    checkCertificateExpiry(
+      event.requestContext.identity.clientCert,
+      deps,
+    ).catch((error) => {
+      deps.logger.error({
+        description: "Error checking certificate expiry",
+        err: error,
+      });
+    });
 
     getSupplier(event.headers, deps)
       .then((supplier: Supplier) => {