Skip to content

CCM-23428: fix sonarqube error in main #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vlasis-Perdikidis merged 3 commits into from
Oct 16, 2026
Merged

CCM-23428: fix sonarqube error in main #747

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45bcf35
fix sonarqube error in main
Vlasis-Perdikidis Oct 16, 2026
18d08d2
update unit test coverage
Vlasis-Perdikidis Oct 16, 2026
e77c140
fix lint issues
Vlasis-Perdikidis Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lambdas/authorizer/src/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,25 @@

expect(metricScope).not.toHaveBeenCalled();
});

it("Should log an error when the certificate expiry check fails", async () => {
mockEvent.requestContext.identity.clientCert = buildCertWithExpiry(
"2025-11-31T14:19:00Z",
);
const error = new Error("Metrics failure");
(metricScope as jest.Mock).mockImplementationOnce(() => async () => {

Check failure on line 148 in lambdas/authorizer/src/__tests__/index.test.ts

View workflow job for this annotation

GitHub Actions / Test stage / Linting 

Move async arrow function to the outer scope
throw error;
});

const handler = createAuthorizerHandler(mockedDeps);
handler(mockEvent, mockContext, mockCallback);
await new Promise(process.nextTick);

expect(mockedDeps.logger.error).toHaveBeenCalledWith({
description: "Error checking certificate expiry",
err: error,
});
});
});

describe("Supplier ID lookup", () => {
Expand Down
10 changes: 9 additions & 1 deletion lambdas/authorizer/src/authorizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ export default function createAuthorizerHandler(
context: Context,
callback: Callback<APIGatewayAuthorizerResult>,
): void => {
checkCertificateExpiry(event.requestContext.identity.clientCert, deps);
checkCertificateExpiry(
event.requestContext.identity.clientCert,
deps,
).catch((error) => {
deps.logger.error({
description: "Error checking certificate expiry",
err: error,
});
});

getSupplier(event.headers, deps)
.then((supplier: Supplier) => {
Expand Down
Loading