Skip to content

Commit eca7a55

Browse files
phoman14github-actions[bot]kelly-sovacool
authored
fix: Standardize 2D PCA output figures across MOSuite function calls (#2)
* Update count_type to list with raw, clean, filt, norm options (default: filt) * Move count_type to first position in Basic category * Update legend_position parameter(s) to list with top, bottom, left, right options * Convert PCA booleans to lists * Reorganize PCA panel categories * Adjust PCA panel parameter order * Update changelog for parameter UI changes * `air format` (GitHub Actions) * Add author handle to changelog entry * Add PCA 2D capsule tests * `air format` (GitHub Actions) * Update changelog for PCA 2D tests * Document PCA 2D color fallback behavior Update color_values help text to describe the MOSuite default palette, supplied-color precedence, generated extra colors, and random fallback behavior. * Align PCA color defaults * docs: update PCA default changelog * docs: add changelog author attribution --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kelly Sovacool, PhD <kelly-sovacool@users.noreply.github.com>
1 parent 7afca54 commit eca7a55

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎.codeocean/app-panel.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
"description": "Size of points in plot",
138138
"type": "text",
139139
"value_type": "string",
140-
"default_value": "1"
140+
"default_value": "3"
141141
},
142142
{
143143
"id": "add_label_id",
@@ -202,7 +202,8 @@
202202
"category": "FvI4Z2eb9sjL47Jt",
203203
"name": "Color values",
204204
"param_name": "color_values",
205-
"description": "Comma-separated color values for groups",
205+
"description": "Comma-separated group colors. Defaults to the MOSuite palette.",
206+
"help_text": "Use color names or hex codes. Supplied colors are used first; if there are more groups than colors, additional colors are generated from the MOSuite palette, with random colors only if that palette is too short.",
206207
"type": "text",
207208
"value_type": "string",
208209
"default_value": "#5954d6,#e1562c,#b80058,#00c6f8,#d163e6,#00a76c,#ff9287,#008cf9,#006e00,#796880,#FFA500,#878500"

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## Development version
44

5+
- Align the PCA color defaults with MOSuite package defaults (#2, @phoman14).
6+
- Document that color palettes fall back to random colors only when too few colors are provided (#2, @phoman14).
57
- Improved the Code Ocean parameter UI for the plot pca 2D capsule (#1, @phoman14).
68

79
## v2.0

‎code/main.R‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ parser$add_argument(
6565
parser$add_argument(
6666
"--point_size",
6767
type = "double",
68-
default = 1,
68+
default = 3,
6969
help = "Size of points in plot"
7070
)
7171
parser$add_argument(
@@ -102,7 +102,7 @@ parser$add_argument(
102102
"--color_values",
103103
type = "character",
104104
default = "#5954d6,#e1562c,#b80058,#00c6f8,#d163e6,#00a76c,#ff9287,#008cf9,#006e00,#796880,#FFA500,#878500",
105-
help = "Comma-separated color values"
105+
help = "Comma-separated group colors. Defaults to the MOSuite palette. Extra group colors are generated when needed."
106106
)
107107

108108
args <- parser$parse_args()

0 commit comments

Comments
 (0)