Skip to content

fix: Standardize 3D PCA output figures across MOSuite function calls - #2

Merged
kelly-sovacool merged 17 commits into
mainfrom
FigOutSync
Jul 9, 2026
Merged

kelly-sovacool merged 17 commits into
mainfrom
FigOutSync

Conversation

@phoman14

@phoman14 phoman14 commented Jul 2, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR aligns the 3D PCA capsule with the package-level figure standardization work. The intent is for 3D PCA figures produced from this capsule to match figures produced by plot_pca_3d() and by MOSuite workflow functions that emit 3D PCA plots.

Changes

  • Use the same default color palette as the MOSuite package for 3D PCA outputs.
  • Align the default 3D PCA point size with the MOSuite package default.
  • Document that random colors are used only as a fallback when the selected or provided palette has too few colors.
  • Keep capsule parameter descriptions focused on the user-facing defaults.
  • Update CHANGELOG.md for the user-facing default changes.
  • Add @phoman14 attribution to the development changelog entries for this PR.

Validation: local capsule tests passed (PASS 12).

Issues

No linked issue.

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Run the capsule in Code Ocean and ensure it completes successfully with no errors. Local capsule tests passed.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • The tests workflow succeeds on the latest commit.

@phoman14 phoman14 changed the title Align 3D PCA capsule plot defaults Standardize 3D PCA output figures across MOSuite function calls Jul 2, 2026
@phoman14
phoman14 requested a review from kelly-sovacool July 2, 2026 20:00

@kelly-sovacool kelly-sovacool left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please first address the requested changes in #1, then once that gets merged into main and merged back into this branch we can review this PR

@phoman14
phoman14 requested a review from kelly-sovacool July 8, 2026 19:54
@kelly-sovacool kelly-sovacool changed the title Standardize 3D PCA output figures across MOSuite function calls fix: Standardize 3D PCA output figures across MOSuite function calls Jul 9, 2026
@kelly-sovacool
kelly-sovacool merged commit 68c218c into main Jul 9, 2026
4 checks passed
@kelly-sovacool
kelly-sovacool deleted the FigOutSync branch July 9, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants