Skip to content

chore(syncweaver): update from CCBR/MOSuite@v0.4.2 - #9

Merged
kelly-sovacool merged 11 commits into
mainfrom
syncweaver-update-CCBR-MOSuite
Sep 2, 2026
Merged

kelly-sovacool merged 11 commits into
mainfrom
syncweaver-update-CCBR-MOSuite

Conversation

@ccbr-bot

@ccbr-bot ccbr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Automated source update orchestrated by NIDAP-Community/syncweaver-orchestrator.

Inputs used

  • source_repository: CCBR/MOSuite
  • lockfile: .syncweaver-lock.json
  • ref: v0.4.2

Updated source paths

  • code/MOSuite

ccbr-bot Bot and others added 5 commits August 28, 2026 22:00
Pass the input multiOmicDataSet directly to MOSuite, expose strict DEG threshold controls, and support optional comma-separated contrast subsets.

_AI assistance: GitHub Copilot_.
_AI assistance: GitHub Copilot_.
_AI assistance: GitHub Copilot_.
@TJoshMeyer

Copy link
Copy Markdown

I don't feel I have enough understanding of Syncweaver to review this PR.

But, I'd love to learn so I can help in the future.

Comment thread .syncweaver-lock.json
"repo_url": "https://github.com/CCBR/MOSuite",
"ref": "v0.4.1",
"git_sha": "4e85d49ab155618d9f6beafd327b6fb87dfa8609"
"ref": "v0.4.2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TJoshMeyer this is the most important part of the PR. Syncweaver opened up this PR because a new version of MOSuite was released (v0.4.2), so it updated the lock file here and included the new version of the package in code/.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh! I think I understand ...

The capsule basically maintains a copy of the entire package, and this "lock file" is that copy? So, when the main package gets updated, because you merge my or someone else's PR, then Syncweaver has to distribute the newly-updated copy of MOSuite to all the MOSuite packages, to make sure they have the latest.

Is that approximately what's going on here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's right! the lockfile documents the version of MOSuite that is kept in this repo. normally this is not necessary (usually dependencies are just installed in a container and loaded with library), but we wanted to help streamline development in case an analyst/dev needs to update code in MOSuite directly in the capsule for a tight deadline.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool and makes sense, now I see it in action! I was honestly not picking up on the Syncweaver discussions in meetings prior to this. Thanks for the insights!

I think this also explains some other things I was running into trying certain changes in my PRs but finding I'd need to change a like a LOT of files. I think I was getting "ahead of syncweaver" sometimes, changing the package and a capsule around the same time in linked PRs. Most of the time it was no issue, but doing some Venn stuff today, I noticed that CoPilot was editing like 25 files in my feature branch, far more than I was intending to edit on this PR, which was scoped rather succinctly. I dug around a bit and convinced myself that my draft Venn capsule PR #10 was basically trying to update the internal locked copy of MOSuite in the capsule to have the changes that were already pending in that Venn capsule Syncweaver PR #9.

Anyways, I'll be let things go their natural course and circle back to #10 once I see #9 merged. Thanks for always being generous with your knowledge, @kelly-sovacool !

@kelly-sovacool

Copy link
Copy Markdown
Member

@TJoshMeyer looks like you accidentally had this branch selected when you were making changes to the venn diagram code (those edits belong in #10). I'll revert them so this PR is a clean update from syncweaver without any other changes to the capsule. Reverted with git revert --no-edit c223f2b..HEAD.

@kelly-sovacool
kelly-sovacool merged commit 9d4a412 into main Sep 2, 2026
4 checks passed
@kelly-sovacool
kelly-sovacool deleted the syncweaver-update-CCBR-MOSuite branch September 2, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants